Refacto : initialize Sentryclient with SentryOptions#118
Merged
Conversation
rxlabz
force-pushed
the
feat/refacto-client
branch
from
October 20, 2020 14:59
11d7b48 to
734c82a
Compare
marandaneto
approved these changes
Oct 20, 2020
marandaneto
left a comment
marandaneto
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
ps: I'd suggest using the changelog and PRs title aligned.
rxlabz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
make SentryClient use a SentryOptions
💡 Motivation and Context
part of unified api goal https://develop.sentry.dev/sdk/unified-api/#hub
💚 How did you test it?
current test update
📝 Checklist
🔮 Next steps