Feat: Use Hint for screenshots#1165
Merged
denrase merged 7 commits intoDec 12, 2022
Merged
Conversation
Contributor
|
Codecov ReportBase: 76.27% // Head: 65.59% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## feat/introduce-hint-data-bag #1165 +/- ##
=================================================================
- Coverage 76.27% 65.59% -10.69%
=================================================================
Files 11 4 -7
Lines 333 186 -147
=================================================================
- Hits 254 122 -132
+ Misses 79 64 -15 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
denrase
marked this pull request as ready for review
December 6, 2022 13:51
denrase
requested review from
brustolin,
krystofwoldrich and
marandaneto
as code owners
December 6, 2022 13:51
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| - Feat: Introduce Hint data bag ([#1136](https://github.com/getsentry/sentry-dart/pull/1136)) | ||
| - Feat: Introduce `Hint` data bag ([#1136](https://github.com/getsentry/sentry-dart/pull/1136)) | ||
| - Feat: Use `Hint` for screenshots ([#1165](https://github.com/getsentry/sentry-dart/pull/1165)) |
Contributor
There was a problem hiding this comment.
- 🚫 The changelog entry seems to be part of an already released section
## 7.0.0.
Consider moving the entry to the## Unreleasedsection, please.
marandaneto
reviewed
Dec 6, 2022
marandaneto
approved these changes
Dec 6, 2022
marandaneto
left a comment
marandaneto
left a comment
Contributor
There was a problem hiding this comment.
Left a last comment, otherwise LGTM.
…-screenshot # Conflicts: # dart/lib/src/hint.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Attaches screenshots to
Hint💡 Motivation and Context
Users can now filter out screenshots with an event processor or through before send. Relates to #1127
💚 How did you test it?
Added (migrated) unit tests.
📝 Checklist