Capture Future errors for Flutter Web automatically#1152
Merged
Conversation
marandaneto
requested review from
brustolin and
krystofwoldrich
as code owners
November 25, 2022 13:24
marandaneto
commented
Nov 25, 2022
| final mechanism = Mechanism( | ||
| type: 'FlutterError', | ||
| handled: true, | ||
| data: { |
Contributor
Author
There was a problem hiding this comment.
Not really needed anymore, people are used to scrolling down and reading all the available context.
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 559d28f | 302.35 ms | 339.53 ms | 37.18 ms |
| 453e1bc | 320.41 ms | 372.73 ms | 52.32 ms |
| 0db91cc | 327.85 ms | 387.31 ms | 59.46 ms |
| 72dfc83 | 298.62 ms | 340.14 ms | 41.52 ms |
| abcdba3 | 354.68 ms | 399.04 ms | 44.36 ms |
| 633cf2e | 289.36 ms | 340.38 ms | 51.02 ms |
| 613760b | 373.42 ms | 399.33 ms | 25.92 ms |
| f4cc744 | 349.53 ms | 394.68 ms | 45.15 ms |
| 870f5eb | 329.45 ms | 369.29 ms | 39.84 ms |
| 379d7a8 | 327.10 ms | 355.39 ms | 28.29 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 559d28f | 5.94 MiB | 6.92 MiB | 1001.70 KiB |
| 453e1bc | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 0db91cc | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 72dfc83 | 5.94 MiB | 6.92 MiB | 1001.71 KiB |
| abcdba3 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 633cf2e | 5.94 MiB | 6.92 MiB | 1001.53 KiB |
| 613760b | 5.94 MiB | 6.92 MiB | 1005.98 KiB |
| f4cc744 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 870f5eb | 5.94 MiB | 6.92 MiB | 1005.77 KiB |
| 379d7a8 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 49a149b | 1296.47 ms | 1320.20 ms | 23.73 ms |
| f922f8f | 1249.53 ms | 1266.51 ms | 16.98 ms |
| 3e5ee37 | 1248.25 ms | 1265.38 ms | 17.13 ms |
| aed5947 | 1268.67 ms | 1281.10 ms | 12.43 ms |
| f4cc744 | 1274.57 ms | 1290.79 ms | 16.22 ms |
| 3e9fb0e | 1262.49 ms | 1280.65 ms | 18.16 ms |
| 633cf2e | 1257.96 ms | 1275.73 ms | 17.77 ms |
| abcdba3 | 1257.31 ms | 1283.49 ms | 26.18 ms |
| 48e79fd | 1282.96 ms | 1296.12 ms | 13.17 ms |
| a609134 | 1254.50 ms | 1265.08 ms | 10.58 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 49a149b | 8.15 MiB | 9.12 MiB | 986.26 KiB |
| f922f8f | 8.15 MiB | 9.13 MiB | 1003.20 KiB |
| 3e5ee37 | 8.15 MiB | 9.12 MiB | 986.23 KiB |
| aed5947 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| f4cc744 | 8.16 MiB | 9.16 MiB | 1.01 MiB |
| 3e9fb0e | 8.15 MiB | 9.12 MiB | 989.77 KiB |
| 633cf2e | 8.15 MiB | 9.12 MiB | 986.26 KiB |
| abcdba3 | 8.15 MiB | 9.12 MiB | 989.76 KiB |
| 48e79fd | 8.16 MiB | 9.15 MiB | 1021.87 KiB |
| a609134 | 8.16 MiB | 9.16 MiB | 1.01 MiB |
Contributor
Author
Contributor
Author
|
@krystofwoldrich or @brustolin would love a review here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Capture Future errors for Flutter Web automatically
💡 Motivation and Context
flutter/flutter#100277 (comment)
💚 How did you test it?
Running Flutter Web and non-Web, throwing
Futureerrors, and checking the error handlers.📝 Checklist
🔮 Next steps