Do not attach headers if Span is NoOp#1143
Merged
Merged
Conversation
marandaneto
requested review from
brustolin and
krystofwoldrich
as code owners
November 18, 2022 08:58
This was referenced Nov 18, 2022
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb1a7c1 | 332.98 ms | 381.55 ms | 48.57 ms |
| 613760b | 373.42 ms | 399.33 ms | 25.92 ms |
| 0db91cc | 327.85 ms | 387.31 ms | 59.46 ms |
| 379d7a8 | 327.10 ms | 355.39 ms | 28.29 ms |
| 3e5ee37 | 317.56 ms | 366.84 ms | 49.28 ms |
| 870f5eb | 329.45 ms | 369.29 ms | 39.84 ms |
| abcdba3 | 354.68 ms | 399.04 ms | 44.36 ms |
| 9c5aec6 | 287.33 ms | 320.94 ms | 33.61 ms |
| 21845e2 | 345.08 ms | 382.82 ms | 37.74 ms |
| 453e1bc | 320.41 ms | 372.73 ms | 52.32 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb1a7c1 | 5.94 MiB | 6.92 MiB | 1005.76 KiB |
| 613760b | 5.94 MiB | 6.92 MiB | 1005.98 KiB |
| 0db91cc | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 379d7a8 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 3e5ee37 | 5.94 MiB | 6.92 MiB | 1001.19 KiB |
| 870f5eb | 5.94 MiB | 6.92 MiB | 1005.77 KiB |
| abcdba3 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 9c5aec6 | 5.94 MiB | 6.92 MiB | 1001.61 KiB |
| 21845e2 | 5.94 MiB | 6.92 MiB | 1003.77 KiB |
| 453e1bc | 5.94 MiB | 6.95 MiB | 1.01 MiB |
marandaneto
enabled auto-merge (squash)
November 18, 2022 09:12
Codecov ReportBase: 91.39% // Head: 91.44% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1143 +/- ##
==========================================
+ Coverage 91.39% 91.44% +0.04%
==========================================
Files 9 9
Lines 186 187 +1
==========================================
+ Hits 170 171 +1
Misses 16 16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Do not attach headers if Span is NoOp
💡 Motivation and Context
getsentry/sentry-java#2376
💚 How did you test it?
📝 Checklist
🔮 Next steps