Disable enableUserInteractionBreadcrumbs on Android when enableAutoNativeBreadcrumbs is disabled#1131
Merged
Merged
Conversation
…tiveBreadcrumbs is disabled
marandaneto
requested review from
brustolin and
krystofwoldrich
as code owners
November 14, 2022 09:08
Contributor
Author
|
@krystofwoldrich do we have this flag on RN? if so, we have to fix it as well. |
marandaneto
commented
Nov 14, 2022
Comment on lines
+13
to
+15
| - Bump Cocoa SDK from v7.30.1 to v7.30.2 ([#1113](https://github.com/getsentry/sentry-dart/pull/1113)) | ||
| - [changelog](https://github.com/getsentry/sentry-cocoa/blob/master/CHANGELOG.md#7302) | ||
| - [diff](https://github.com/getsentry/sentry-cocoa/compare/7.30.1...7.30.2) |
Contributor
Author
There was a problem hiding this comment.
@brustolin you have changed the wrong entry for the changelog, so fixing it here on the fly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1131 +/- ##
==========================================
+ Coverage 90.00% 90.02% +0.01%
==========================================
Files 108 115 +7
Lines 3413 3560 +147
==========================================
+ Hits 3072 3205 +133
- Misses 341 355 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 21845e2 | 345.08 ms | 382.82 ms | 37.74 ms |
| 633cf2e | 289.36 ms | 340.38 ms | 51.02 ms |
| 0ceb89c | 304.57 ms | 357.18 ms | 52.61 ms |
| 3e5ee37 | 317.56 ms | 366.84 ms | 49.28 ms |
| eecbbca | 324.37 ms | 352.49 ms | 28.12 ms |
| d7758e8 | 300.12 ms | 349.88 ms | 49.76 ms |
| 3a69405 | 334.34 ms | 369.19 ms | 34.85 ms |
| f922f8f | 332.31 ms | 374.67 ms | 42.37 ms |
| 25e9b59 | 307.00 ms | 348.83 ms | 41.83 ms |
| 6957bfd | 325.88 ms | 380.30 ms | 54.43 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 21845e2 | 5.94 MiB | 6.92 MiB | 1003.77 KiB |
| 633cf2e | 5.94 MiB | 6.92 MiB | 1001.53 KiB |
| 0ceb89c | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 3e5ee37 | 5.94 MiB | 6.92 MiB | 1001.19 KiB |
| eecbbca | 5.94 MiB | 6.89 MiB | 975.78 KiB |
| d7758e8 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 3a69405 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| f922f8f | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 25e9b59 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 6957bfd | 5.94 MiB | 6.95 MiB | 1.01 MiB |
brustolin
approved these changes
Nov 14, 2022
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3a69405 | 1292.84 ms | 1303.96 ms | 11.12 ms |
| 72dfc83 | 1262.50 ms | 1289.75 ms | 27.25 ms |
| 5603ab2 | 1268.47 ms | 1280.73 ms | 12.26 ms |
| 9c5aec6 | 1266.51 ms | 1274.65 ms | 8.14 ms |
| 3e9fb0e | 1262.49 ms | 1280.65 ms | 18.16 ms |
| b728df4 | 1287.43 ms | 1293.94 ms | 6.51 ms |
| 1c6eb5b | 1277.85 ms | 1285.71 ms | 7.86 ms |
| abcdba3 | 1257.31 ms | 1283.49 ms | 26.18 ms |
| 6d317ea | 1277.27 ms | 1287.47 ms | 10.20 ms |
| 04db237 | 1273.29 ms | 1306.50 ms | 33.21 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3a69405 | 8.15 MiB | 9.15 MiB | 1018.56 KiB |
| 72dfc83 | 8.15 MiB | 9.12 MiB | 987.30 KiB |
| 5603ab2 | 8.15 MiB | 9.12 MiB | 990.57 KiB |
| 9c5aec6 | 8.15 MiB | 9.12 MiB | 986.23 KiB |
| 3e9fb0e | 8.15 MiB | 9.12 MiB | 989.77 KiB |
| b728df4 | 8.15 MiB | 9.15 MiB | 1020.72 KiB |
| 1c6eb5b | 8.15 MiB | 9.12 MiB | 986.27 KiB |
| abcdba3 | 8.15 MiB | 9.12 MiB | 989.76 KiB |
| 6d317ea | 8.15 MiB | 9.12 MiB | 986.26 KiB |
| 04db237 | 8.15 MiB | 9.13 MiB | 1003.16 KiB |
marandaneto
enabled auto-merge (squash)
November 14, 2022 10:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
New feature was added https://docs.sentry.io/platforms/android/enriching-events/breadcrumbs/#disable-automatic-breadcrumbs but not disabled here.
💚 How did you test it?
📝 Checklist
🔮 Next steps