Add SentryRequest context for HttpException and SocketException#1118
Merged
Conversation
ueman
requested review from
brustolin,
krystofwoldrich and
marandaneto
as code owners
November 9, 2022 10:54
ueman
commented
Nov 9, 2022
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1118 +/- ##
==========================================
- Coverage 90.09% 89.95% -0.14%
==========================================
Files 117 110 -7
Lines 3605 3456 -149
==========================================
- Hits 3248 3109 -139
+ Misses 357 347 -10 ☔ View full report in Codecov by Sentry. |
ueman
commented
Nov 9, 2022
marandaneto
reviewed
Nov 9, 2022
marandaneto
reviewed
Nov 9, 2022
marandaneto
reviewed
Nov 16, 2022
marandaneto
reviewed
Nov 16, 2022
marandaneto
reviewed
Nov 16, 2022
marandaneto
reviewed
Nov 16, 2022
Collaborator
Author
|
The failures come again because of the newly introduced |
Contributor
yeah, it's pana, after publishing it, it will be green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Add SentryRequest context for HttpException and SocketException.
Also SocketException and FileSystemException have an underlying OSError, which is now reported as underlying exception.
I've also done some small refactoring of moving the enricher event processors into the event processor folder. I've also added a new constructor to
SentryRequestand removed duplicated code.💡 Motivation and Context
HttpExceptions and SocketException can now be filtered via the request context.
💚 How did you test it?
Added new tests.
📝 Checklist
🔮 Next steps