Add mechanism to Dio Http Client error#1114
Merged
Merged
Conversation
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d7758e8 | 300.12 ms | 349.88 ms | 49.76 ms |
| 4efee31 | 308.92 ms | 368.68 ms | 59.76 ms |
| ef2f368 | 350.06 ms | 429.44 ms | 79.38 ms |
| 3e9fb0e | 329.14 ms | 359.16 ms | 30.02 ms |
| f922f8f | 332.31 ms | 374.67 ms | 42.37 ms |
| 0ceb89c | 304.57 ms | 357.18 ms | 52.61 ms |
| 3e5ee37 | 317.56 ms | 366.84 ms | 49.28 ms |
| 56810ff | 309.72 ms | 352.26 ms | 42.54 ms |
| 559d28f | 302.35 ms | 339.53 ms | 37.18 ms |
| 633cf2e | 289.36 ms | 340.38 ms | 51.02 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d7758e8 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 4efee31 | 5.94 MiB | 6.92 MiB | 1003.76 KiB |
| ef2f368 | 5.94 MiB | 6.89 MiB | 975.81 KiB |
| 3e9fb0e | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| f922f8f | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 0ceb89c | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 3e5ee37 | 5.94 MiB | 6.92 MiB | 1001.19 KiB |
| 56810ff | 5.94 MiB | 6.92 MiB | 1001.71 KiB |
| 559d28f | 5.94 MiB | 6.92 MiB | 1001.70 KiB |
| 633cf2e | 5.94 MiB | 6.92 MiB | 1001.53 KiB |
marandaneto
marked this pull request as ready for review
November 9, 2022 07:45
marandaneto
requested review from
brustolin and
krystofwoldrich
as code owners
November 9, 2022 07:45
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1114 +/- ##
==========================================
+ Coverage 90.17% 90.18% +0.01%
==========================================
Files 116 116
Lines 3583 3588 +5
==========================================
+ Hits 3231 3236 +5
Misses 352 352 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d7758e8 | 1271.69 ms | 1288.08 ms | 16.39 ms |
| 1c6eb5b | 1277.85 ms | 1285.71 ms | 7.86 ms |
| 72dfc83 | 1262.50 ms | 1289.75 ms | 27.25 ms |
| 9c5aec6 | 1266.51 ms | 1274.65 ms | 8.14 ms |
| 5603ab2 | 1268.47 ms | 1280.73 ms | 12.26 ms |
| 6d317ea | 1277.27 ms | 1287.47 ms | 10.20 ms |
| eb1a7c1 | 1281.25 ms | 1295.40 ms | 14.15 ms |
| 4efee31 | 1270.33 ms | 1285.75 ms | 15.42 ms |
| 559d28f | 1265.04 ms | 1288.96 ms | 23.92 ms |
| 0ceb89c | 1252.02 ms | 1271.78 ms | 19.75 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d7758e8 | 8.15 MiB | 9.12 MiB | 989.76 KiB |
| 1c6eb5b | 8.15 MiB | 9.12 MiB | 986.27 KiB |
| 72dfc83 | 8.15 MiB | 9.12 MiB | 987.30 KiB |
| 9c5aec6 | 8.15 MiB | 9.12 MiB | 986.23 KiB |
| 5603ab2 | 8.15 MiB | 9.12 MiB | 990.57 KiB |
| 6d317ea | 8.15 MiB | 9.12 MiB | 986.26 KiB |
| eb1a7c1 | 8.15 MiB | 9.13 MiB | 1000.10 KiB |
| 4efee31 | 8.15 MiB | 9.12 MiB | 991.35 KiB |
| 559d28f | 8.15 MiB | 9.12 MiB | 987.32 KiB |
| 0ceb89c | 8.15 MiB | 9.12 MiB | 989.78 KiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Align spec for HTTP Client errors https://develop.sentry.dev/sdk/features/#http-client-errors
Dio events now are possible to be searchable via mechanism.
💚 How did you test it?
📝 Checklist
🔮 Next steps