VendorId should be a String#1112
Merged
Merged
Conversation
marandaneto
requested review from
brustolin and
krystofwoldrich
as code owners
November 7, 2022 16:19
Contributor
Author
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 613760b | 373.42 ms | 399.33 ms | 25.92 ms |
| 559d28f | 302.35 ms | 339.53 ms | 37.18 ms |
| 9f9f94f | 331.04 ms | 368.92 ms | 37.88 ms |
| 2f8f173 | 323.31 ms | 373.29 ms | 49.97 ms |
| af2d175 | 279.08 ms | 312.37 ms | 33.29 ms |
| 3e5ee37 | 317.56 ms | 366.84 ms | 49.28 ms |
| 48e79fd | 354.22 ms | 391.46 ms | 37.24 ms |
| 7f2b01d | 304.94 ms | 345.71 ms | 40.78 ms |
| f922f8f | 332.31 ms | 374.67 ms | 42.37 ms |
| a49594a | 282.27 ms | 344.84 ms | 62.57 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 613760b | 5.94 MiB | 6.92 MiB | 1005.98 KiB |
| 559d28f | 5.94 MiB | 6.92 MiB | 1001.70 KiB |
| 9f9f94f | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 2f8f173 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| af2d175 | 5.94 MiB | 6.92 MiB | 1001.83 KiB |
| 3e5ee37 | 5.94 MiB | 6.92 MiB | 1001.19 KiB |
| 48e79fd | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 7f2b01d | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| f922f8f | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| a49594a | 5.94 MiB | 6.95 MiB | 1.01 MiB |
4 tasks
Contributor
|
I guess this need to wait for Android SDK. |
Contributor
Author
its in the making, no need to block the PR tho. |
brustolin
approved these changes
Nov 8, 2022
Contributor
Author
|
@markushi can we cut a release on Android so we can unblock this? |
Member
|
@marandaneto the required |
marandaneto
enabled auto-merge (squash)
November 16, 2022 19:49
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 04db237 | 1273.29 ms | 1306.50 ms | 33.21 ms |
| 559d28f | 1265.04 ms | 1288.96 ms | 23.92 ms |
| 4efee31 | 1270.33 ms | 1285.75 ms | 15.42 ms |
| eb1a7c1 | 1281.25 ms | 1295.40 ms | 14.15 ms |
| 0db91cc | 1267.63 ms | 1279.69 ms | 12.06 ms |
| 6957bfd | 1283.80 ms | 1289.00 ms | 5.20 ms |
| 870f5eb | 1267.78 ms | 1286.86 ms | 19.08 ms |
| a49594a | 1284.83 ms | 1313.29 ms | 28.45 ms |
| 6d317ea | 1277.27 ms | 1287.47 ms | 10.20 ms |
| f922f8f | 1249.53 ms | 1266.51 ms | 16.98 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 04db237 | 8.15 MiB | 9.13 MiB | 1003.16 KiB |
| 559d28f | 8.15 MiB | 9.12 MiB | 987.32 KiB |
| 4efee31 | 8.15 MiB | 9.12 MiB | 991.35 KiB |
| eb1a7c1 | 8.15 MiB | 9.13 MiB | 1000.10 KiB |
| 0db91cc | 8.15 MiB | 9.15 MiB | 1018.56 KiB |
| 6957bfd | 8.15 MiB | 9.15 MiB | 1020.71 KiB |
| 870f5eb | 8.15 MiB | 9.13 MiB | 1000.08 KiB |
| a49594a | 8.16 MiB | 9.16 MiB | 1.00 MiB |
| 6d317ea | 8.15 MiB | 9.12 MiB | 986.26 KiB |
| f922f8f | 8.15 MiB | 9.13 MiB | 1003.20 KiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
getsentry/team-mobile#67
💚 How did you test it?
📝 Checklist
It's technically a breaking change but nobody should be using it directly.
Also its a bug fixing since the previous type does not work.
🔮 Next steps