Use new constructor which respects Frame Tracking feature flag#1087
Merged
marandaneto merged 3 commits intoOct 25, 2022
Conversation
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Use new constructor which respects Frame Tracking feature flag ([#1087](https://github.com/getsentry/sentry-dart/pull/1087))If none of the above apply, you can opt out of this check by adding |
4 tasks
Contributor
|
Thanks @markushi |
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 21845e2 | 1279.37 ms | 1298.81 ms | 19.45 ms |
| ef2f368 | 1259.12 ms | 1277.04 ms | 17.92 ms |
| 6d317ea | 1277.27 ms | 1287.47 ms | 10.20 ms |
| 1c6eb5b | 1277.85 ms | 1285.71 ms | 7.86 ms |
| 322aa66 | 1251.68 ms | 1275.52 ms | 23.84 ms |
| 9c5aec6 | 1266.51 ms | 1274.65 ms | 8.14 ms |
| 56810ff | 1267.59 ms | 1293.48 ms | 25.89 ms |
| eecbbca | 1264.90 ms | 1286.33 ms | 21.43 ms |
| af2d175 | 1280.37 ms | 1282.24 ms | 1.88 ms |
| 3e5ee37 | 1248.25 ms | 1265.38 ms | 17.13 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 21845e2 | 8.15 MiB | 9.12 MiB | 991.34 KiB |
| ef2f368 | 8.15 MiB | 9.10 MiB | 965.24 KiB |
| 6d317ea | 8.15 MiB | 9.12 MiB | 986.26 KiB |
| 1c6eb5b | 8.15 MiB | 9.12 MiB | 986.27 KiB |
| 322aa66 | 8.15 MiB | 9.12 MiB | 992.53 KiB |
| 9c5aec6 | 8.15 MiB | 9.12 MiB | 986.23 KiB |
| 56810ff | 8.15 MiB | 9.12 MiB | 987.35 KiB |
| eecbbca | 8.15 MiB | 9.10 MiB | 965.26 KiB |
| af2d175 | 8.15 MiB | 9.12 MiB | 986.22 KiB |
| 3e5ee37 | 8.15 MiB | 9.12 MiB | 986.23 KiB |
marandaneto
changed the base branch from
main
to
deps/flutter/scripts/update-android.sh/6.6.0
October 25, 2022 12:10
…/activity-frames-tracker-feature-flag
…/activity-frames-tracker-feature-flag
marandaneto
approved these changes
Oct 25, 2022
marandaneto
marked this pull request as ready for review
October 25, 2022 13:21
marandaneto
requested review from
brustolin and
krystofwoldrich
as code owners
October 25, 2022 13:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Frame Tracking can be enabled/disabled in future, this PR adapts the necessary calls into the Android SDK.
💡 Motivation and Context
Related Android PR: getsentry/sentry-java#2314
getsentry/sentry-java#2314 (comment)
💚 How did you test it?
📝 Checklist
🔮 Next steps