Fix: SentryDevice cast error#1059
Merged
Merged
Conversation
denrase
marked this pull request as ready for review
October 10, 2022 09:25
denrase
requested review from
brustolin,
krystofwoldrich and
marandaneto
as code owners
October 10, 2022 09:25
Codecov ReportBase: 91.37% // Head: 91.37% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1059 +/- ##
=======================================
Coverage 91.37% 91.37%
=======================================
Files 9 9
Lines 197 197
=======================================
Hits 180 180
Misses 17 17 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixes an issue wehre
SentryDevicecould not be parsed.💡 Motivation and Context
The double values
screen_height_pixelsandscreen_width_pixelscould not be parsed, wich lead to a failingloadContextsIntegration.This was observed on an iPhone 14 Pro Simulator on iOS 16:
💚 How did you test it?
Added unit test.
📝 Checklist
🔮 Next steps
I did not trace why we unexpectedly have double values here. This might have to do with a behaviour change of either the iOS SDK or with iOS 16.