Skip to content

Pin sentry version#1020

Merged
marandaneto merged 5 commits into
getsentry:mainfrom
timekone:pin-sentry-version
Sep 28, 2022
Merged

Pin sentry version#1020
marandaneto merged 5 commits into
getsentry:mainfrom
timekone:pin-sentry-version

Conversation

@timekone

@timekone timekone commented Sep 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Resolves #1021

flutter_sentry and sentry packages versions should be in sync. Using caret symbol ^ may cause mismatch of versions and a build fail.

Example:
sentry_flutter 6.7.0 depends on sentry: ^6.7.0

A user has sentry_flutter: 6.7.0 (without caret symbol) in their pubspec.yaml.

sentry_flutter: 6.7.0 depends on SentryTracer.addMeasurements().
SentryTracer.addMeasurements() was removed in sentry 6.11.0.
This means that sentry_flutter 6.7.0 is incompatible with sentry 6.11.0.

@codecov-commenter

codecov-commenter commented Sep 26, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Base: 90.05% // Head: 90.12% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (48083eb) compared to base (fa7e619).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
+ Coverage   90.05%   90.12%   +0.07%     
==========================================
  Files         105      114       +9     
  Lines        3357     3554     +197     
==========================================
+ Hits         3023     3203     +180     
- Misses        334      351      +17
Impacted Files Coverage Δ
dio/lib/src/breadcrumb_client_adapter.dart 80.00% <0.00%> (ø)
dio/lib/src/sentry_dio_extension.dart 83.33% <0.00%> (ø)
dio/lib/src/sentry_dio_client_adapter.dart 77.77% <0.00%> (ø)
dio/lib/src/dio_event_processor.dart 95.58% <0.00%> (ø)
logging/lib/src/logging_integration.dart 90.47% <0.00%> (ø)
dio/lib/src/tracing_client_adapter.dart 85.00% <0.00%> (ø)
logging/lib/src/extension.dart 100.00% <0.00%> (ø)
dio/lib/src/failed_request_interceptor.dart 100.00% <0.00%> (ø)
dio/lib/src/sentry_transformer.dart 94.44% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@krystofwoldrich krystofwoldrich mentioned this pull request Sep 26, 2022
Closed
11 tasks
@marandaneto

marandaneto commented Sep 26, 2022

Copy link
Copy Markdown
Contributor

@timekone thanks.
This script has to be patched as well.

@kuhnroyal

kuhnroyal commented Sep 26, 2022

Copy link
Copy Markdown
Contributor

I think this may reduce the pana score, may need some adaptions as well there.

@timekone

timekone commented Sep 26, 2022

Copy link
Copy Markdown
Contributor Author

I think this may reduce the pana score, may need some adaptions as well there.

Do you think so? I ran pana locally, and it returned the max score.

@marandaneto

marandaneto commented Sep 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

@timekone please add a changelog entry, so we can merge it, thanks for doing this.

@kuhnroyal

kuhnroyal commented Sep 27, 2022

Copy link
Copy Markdown
Contributor

I think this may reduce the pana score, may need some adaptions as well there.

Do you think so? I ran pana locally, and it returned the max score.

Ah nice, that is good. I thought pub and pana once had a warning for pinned versions in libraries.

@marandaneto
marandaneto enabled auto-merge (squash) September 28, 2022 07:49
@marandaneto
marandaneto merged commit f92ec54 into getsentry:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brustolin brustolin Awaiting requested review from brustolin
@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich
1 more reviewer
@marandaneto marandaneto marandaneto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sentry_flutter 6.7.0 build fail after the release of sentry 6.11.0

4 participants

@timekone @codecov-commenter @marandaneto @kuhnroyal