sort native breadcrumbs

denrase · denrase · commit c91014271518 · 2023-02-28T11:13:10.000+01:00
diff --git a/flutter/lib/src/integrations/load_contexts_integration.dart b/flutter/lib/src/integrations/load_contexts_integration.dart
@@ -150,6 +150,9 @@ class _LoadContextsIntegrationEventProcessor extends EventProcessor {
           );
           breadcrumbs.add(breadcrumb);
         }
+        breadcrumbs.sort((a, b) {
+          return a.timestamp.compareTo(b.timestamp);
+        });
         event = event.copyWith(breadcrumbs: breadcrumbs);
       }
 
diff --git a/flutter/test/integrations/load_contexts_integration_test.dart b/flutter/test/integrations/load_contexts_integration_test.dart
@@ -85,6 +85,34 @@ void main() {
       expect(event.breadcrumbs!.length, 1);
       expect(event.breadcrumbs!.first.message, 'event');
     });
+
+    test('should sort native breadcrumbs by timestamp', () async {
+      fixture.options.enableScopeSync = true;
+
+      final beforeCrumb = Breadcrumb(
+          message: 'before', timestamp: DateTime.fromMicrosecondsSinceEpoch(0));
+      final afterCrumb = Breadcrumb(
+          message: 'after',
+          timestamp: DateTime.fromMicrosecondsSinceEpoch(1000));
+      Map<String, dynamic> loadContexts = {
+        'breadcrumbs': [afterCrumb.toJson(), beforeCrumb.toJson()]
+      };
+
+      var event = SentryEvent(breadcrumbs: []);
+
+      final future = Future.value(loadContexts);
+      when(fixture.methodChannel.invokeMethod<dynamic>('loadContexts'))
+          .thenAnswer((_) => future);
+      _channel.setMockMethodCallHandler((MethodCall methodCall) async {});
+
+      final integration = LoadContextsIntegration(fixture.methodChannel);
+      integration.call(fixture.hub, fixture.options);
+      event = (await fixture.options.eventProcessors.first.apply(event))!;
+
+      expect(event.breadcrumbs!.length, 2);
+      expect(event.breadcrumbs![0].message, 'before');
+      expect(event.breadcrumbs![1].message, 'after');
+    });
   });
 }
 

Original file line number	Diff line number	Diff line change
`@@ -150,6 +150,9 @@ class _LoadContextsIntegrationEventProcessor extends EventProcessor {`
`150`	`150`	`);`
`151`	`151`	`breadcrumbs.add(breadcrumb);`
`152`	`152`	`}`
	`153`	`+ breadcrumbs.sort((a, b) {`
	`154`	`+ return a.timestamp.compareTo(b.timestamp);`
	`155`	`+ });`
`153`	`156`	`event = event.copyWith(breadcrumbs: breadcrumbs);`
`154`	`157`	`}`
`155`	`158`