fix: guard feedback success callback

cursoragent · claude · cursoragent · commit 0e775e1fba11 · 2026-04-13T13:28:13.000Z
Catch exceptions from onSubmitSuccess so the success snackbar and

dismissal still run after successful submission.

Add a widget test that reproduces a throwing callback and

asserts the feedback view still closes and shows success.

Co-Authored-By: Claude &lt;noreply@anthropic.com&gt;
diff --git a/packages/flutter/lib/src/feedback/sentry_feedback_widget.dart b/packages/flutter/lib/src/feedback/sentry_feedback_widget.dart
@@ -8,6 +8,7 @@ import 'sentry_feedback_options.dart';
 import 'package:flutter/services.dart';
 import 'sentry_logo.dart';
 import '../replay/integration.dart';
+import '../utils/internal_logger.dart';
 
 class SentryFeedbackWidget extends StatefulWidget {
   SentryFeedbackWidget({
@@ -388,7 +389,15 @@ class _SentryFeedbackWidgetState extends State<SentryFeedbackWidget> {
 
     if (!mounted) return;
 
-    widget.options.onSubmitSuccess?.call(feedback, sentryId);
+    try {
+      widget.options.onSubmitSuccess?.call(feedback, sentryId);
+    } catch (exception, stackTrace) {
+      internalLogger.error(
+        'SentryFeedbackWidget failed to execute onSubmitSuccess callback',
+        error: exception,
+        stackTrace: stackTrace,
+      );
+    }
     _showSuccessSnackBar();
     _dismiss(pendingAssociatedEventId: false);
   }
diff --git a/packages/flutter/test/feedback/sentry_feedback_widget_test.dart b/packages/flutter/test/feedback/sentry_feedback_widget_test.dart
@@ -889,6 +889,31 @@ void main() {
         expect(receivedEventId, isNotNull);
         expect(receivedEventId, isNot(const SentryId.empty()));
       });
+
+      testWidgets('dismisses and shows snackbar when onSubmitSuccess throws',
+          (tester) async {
+        fixture.options.feedback.onSubmitSuccess = (feedback, eventId) {
+          throw Exception('onSubmitSuccess failed');
+        };
+
+        await fixture.pumpFeedbackHost(tester);
+
+        await tester.tap(find.text('Show Feedback'));
+        await tester.pumpAndSettle();
+
+        await tester.enterText(
+          find.byKey(const ValueKey('sentry_feedback_message_textfield')),
+          'callback-throw-test',
+        );
+        await tester.tap(find.text('Send Bug Report'));
+        await tester.pumpAndSettle();
+
+        expect(tester.takeException(), isNull);
+        expect(find.byType(SentryFeedbackWidget), findsNothing);
+        expect(find.byType(SnackBar), findsOneWidget);
+        expect(find.text('Thank you for your report!'), findsOneWidget);
+        expect(SentryFeedbackWidget.pendingAssociatedEventId, isNull);
+      });
     });
   });
 }
