ref(attributes): Deprecate sentry.span.source and change backfill status of sentry.source - #510
Merged
Merged
Conversation
…tatus of `sentry.source`
Lms24
requested review from
a team,
cleptric,
mjq and
nsdeschenes
as code owners
July 16, 2026 12:16
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
6 tasks
cleptric
approved these changes
Jul 16, 2026
Lms24
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 17, 2026
….name.source` common attribute (#18745) <!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> ## DESCRIBE YOUR PR Replaces the `sentry.span.source` attribute (deprecation pending via getsentry/sentry-conventions#510) with [`sentry.segment.name.source`](https://getsentry.github.io/sentry-conventions/attributes/sentry/#sentry-segment-name-source) which must now exclusively be set on segment spans. ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates
sentry.span.sourcewithout a direct replacement. We addedsentry.segment.name.sourcebefore but the expectation here is that this attribute must only ever be set on segment spans. Therefore, we don't want to normalize or backfill it fromsentry.span.source.Also required to change the
sentry.sourcebackfilling status, since its replacement no longer gets backfilled.Side-note/context, this does not concern setting
transaction_info.sourceon transaction events. This we'll leave as-is for transactions. We intendedsentry.span.sourceto be the replacement but then reconsidered the approach. Since the naming was less than ideal and the JS SDK also set it on non-segment spans, we decided on hopefully the final attribute now.