feat(attributes): Deprecate sentry.frames.* attributes - #500
Merged
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
buenaflor
marked this pull request as ready for review
July 14, 2026 10:09
buenaflor
requested review from
a team,
Lms24,
cleptric,
mjq and
nsdeschenes
as code owners
July 14, 2026 10:09
Contributor
There was a problem hiding this comment.
Pull request overview
Adds newly deprecated sentry.frames.* attribute definitions and wires them into the existing frames.* and app.vitals.frames.*.count attributes via alias metadata, keeping generated Python and TypeScript registries in sync with the model JSON files.
Changes:
- Added deprecated attribute definitions for
sentry.frames.frozen,sentry.frames.slow, andsentry.frames.total(new model JSON + generated Python/TS constants and metadata). - Updated
frames.*andapp.vitals.frames.*.countattributes to includesentry.frames.*as additional aliases (plus corresponding generated metadata/doc updates). - Updated generated type maps/unions to include the new
sentry.frames.*keys in both Python and TypeScript outputs.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| python/src/sentry_conventions/attributes.py | Generated Python registry updated with new sentry.frames.* constants, metadata entries, and alias lists. |
| model/attributes/sentry/sentry__frames__frozen.json | New deprecated sentry.frames.frozen attribute definition. |
| model/attributes/sentry/sentry__frames__slow.json | New deprecated sentry.frames.slow attribute definition. |
| model/attributes/sentry/sentry__frames__total.json | New deprecated sentry.frames.total attribute definition. |
| model/attributes/frames/frames__frozen.json | Adds sentry.frames.frozen as an alias for frames.frozen. |
| model/attributes/frames/frames__slow.json | Adds sentry.frames.slow as an alias for frames.slow. |
| model/attributes/frames/frames__total.json | Adds sentry.frames.total as an alias for frames.total. |
| model/attributes/app/app__vitals__frames__frozen__count.json | Adds sentry.frames.frozen as an alias for the canonical app.vitals.frames.frozen.count. |
| model/attributes/app/app__vitals__frames__slow__count.json | Adds sentry.frames.slow as an alias for the canonical app.vitals.frames.slow.count. |
| model/attributes/app/app__vitals__frames__total__count.json | Adds sentry.frames.total as an alias for the canonical app.vitals.frames.total.count. |
| javascript/sentry-conventions/src/attributes.ts | Generated TypeScript registry updated with new constants/types/metadata and alias doc links. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
buenaflor
changed the title
sentry.frames.* attributes
loewenheim
approved these changes
Jul 14, 2026
Dav1dde
approved these changes
Jul 14, 2026
Dav1dde
force-pushed
the
feat/deprecate-sentry-frames
branch
from
July 15, 2026 06:44
62abf3d to
3f6fe78
Compare
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds deprecated definitions for
sentry.frames.slow,sentry.frames.frozen, andsentry.frames.total.Did not add
sentry.frames.delaysince that is not renamed in relay.PR Checklist
If an attribute was added:
If an attribute was deprecated: