feat(attributes): Add navigation.origin attribute and deprecate SvelteKit routing attributes - #467
Merged
Merged
Conversation
…ltekit-specific routing attributes
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Lms24
marked this pull request as ready for review
July 8, 2026 08:05
Lms24
changed the title
navigation.origin attribute and deprecate sveltekit-specific routing attributesnavigation.origin attribute and deprecate sveltekitrouting attributes
Lms24
changed the title
navigation.origin attribute and deprecate sveltekitrouting attributesnavigation.origin attribute and deprecate sveltekit routing attributes
Lms24
changed the title
navigation.origin attribute and deprecate sveltekit routing attributesnavigation.origin attribute and deprecate SvelteKit routing attributes
nsdeschenes
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new, generic
navigation.originattribute (analogously to the already existingnavigation.typeattribute). The purpose is to record the origin route a client-side navigation was started on. This information is already collected by some of our routing instrumentation (like Sveltekit) but in a less than ideal way.Therefore, this PR also deprecates a few Sveltekit-specific attributes:
sentry.sveltekit.navigation.type(to be replaced bynavigation.type)sentry.sveltekit.navigation.from(to be replaced bynavigation.origin)sentry.sveltekit.navigation.to(no replacement, as it's redundant with span name and url attributes)PR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.If an attribute was added:
nextjs.function_id, notfunction_id)apply_scrubbing(i.e.manualorauto. Useneveronly for values that should never be scrubbed such as IDs)If an attribute was deprecated: