fix(sentry): Deprecate sentry.trace.parent_span_id - #287
Merged
Conversation
mjq
requested review from
a team,
Lms24,
cleptric,
lcian and
nsdeschenes
as code owners
March 14, 2026 02:11
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧Deps
Deps Dev
Other
🤖 This preview updates automatically when you update the PR. |
This attribute was replaced with log's top level `span_id` field and should no longer be used. Because it was replaced with a field rather than a different attribute, I don't think there's a way to express the new attribute in the attribute JSON.
mjq
force-pushed
the
mjq/deprecate-trace-parent-span-id
branch
from
March 16, 2026 15:04
3c972c0 to
c9b6ce1
Compare
Lms24
approved these changes
Mar 16, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
Thanks, makes sense to me! Two minor comments, otherwise LGTM.
| "is_in_otel": false, | ||
| "example": "b0e6f15b45c36b12", | ||
| "deprecation": { | ||
| "_status": null |
Member
There was a problem hiding this comment.
just to confirm: Since nothing in the product relies on this, null is the correct status here?
Member
Author
There was a problem hiding this comment.
Yes, I believe so. We also don't have another attribute to backfill or migrate to, since the new value is a field instead.
| "_status": null | ||
| }, | ||
| "changelog": [ | ||
| { |
Member
There was a problem hiding this comment.
l: We should add a "version": "next" entry to the changelog and mention this PR plus the deprecation.
Member
Author
There was a problem hiding this comment.
@Lms24 Good catch, thanks! Would you mind confirming that I got the change right? It's my first time using the attribute changelog property. 7e47a3f#diff-ec824ae2ecf3522dfc5515d7d669b843cbf51c51c1ce9c4365cc89cbde3e78e2
mjq
force-pushed
the
mjq/deprecate-trace-parent-span-id
branch
from
March 16, 2026 17:13
eaa0223 to
3c4270b
Compare
mjq
force-pushed
the
mjq/deprecate-trace-parent-span-id
branch
from
March 16, 2026 17:15
3c4270b to
7e47a3f
Compare
Lms24
approved these changes
Mar 17, 2026
| "_status": null | ||
| }, | ||
| "changelog": [ | ||
| { |
This was referenced Apr 13, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This attribute was replaced with log's top level
span_idfield and should no longer be used. Because it was replaced with a field rather than a different attribute, I don't think there's a way to express the new location for this data in the attribute JSON.PR Checklist
yarn testand verified that the tests pass.yarn generate && yarn formatto generate and format code and docs.If an attribute was deprecated: