ref(attributes): Update sentry.span.source with known values - #214
Merged
Conversation
lcian
approved these changes
Jan 9, 2026
lcian
left a comment
lcian
left a comment
Member
There was a problem hiding this comment.
Thanks. Yeah I think it would make sense to add a field to store longer descriptions, OTEL for instance uses note for this purpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the known values for the
sentry.span.sourceattribute, taken from https://develop.sentry.dev/sdk/data-model/event-payloads/transaction/#transaction-annotations. I'm also open to adding the entire description of the purpose here because the dev docs page is going to be outdated soon (as in transaction_info, not existing in span v2). Though not sure if we want a long description inbrief(and there's no other field that fits better (?)).Side question: Should we add a longer
descriptionfield? We could also use that to link to OTel specifications as suggested in #210