feat(attributes): Add sentry.normalized_db_query - #194

Generated by 🚫 dangerJS against 07e210e

We might want to mark this as deprecated then and add a back-fill property to let Relay write it into the correct field. cc @loewenheim

What attribute would it be backfilled to?

@cleptric

We might want to mark this as deprecated then and add a back-fill property to let Relay write it into the correct field.

sentry.normalized_description currently holds several different types of values, depending on the type of span (op). So, this isn't a 1:1 replacement. We'll similarly move the other types of values into their own semantic attributes.

Ok, I think I understand. So db.query.text, while it should be already sanitized (https://opentelemetry.io/docs/specs/semconv/database/database-spans/#sanitization-of-dbquerytext), might not be, so we sanitize it again and use sentry.normalized_db_query in the product. And our SDKs will send db.query.text.

Ok, I think I understand. So db.query.text, while it should be already sanitized (https://opentelemetry.io/docs/specs/semconv/database/database-spans/#sanitization-of-dbquerytext), might not be, so we sanitize it again and use sentry.normalized_db_query in the product. And our SDKs will send db.query.text.

Yup! Relay would just add this field so it can be used in the product.

db.query.text shouldn't actually be pre-sanitized, it should contain the raw query. We just normalize the raw query for the sake of grouping in the product side (e.g. backend insights). V1 spans contained the raw query in the span description field, and relay normalizes/scrubs it. Now, we'd like to undergo the same normalization for V2 spans, except the raw query is in db.query.text but we don't want to write it back to the same field, and instead to this new field (so we can preserve the raw query).