Skip to content

ref(internal): Remove sentry._internal from conventions - #185

Merged
Dav1dde merged 1 commit into
mainfrom
dav1d/remove-internal
Nov 3, 2025
Merged

ref(internal): Remove sentry._internal from conventions#185
Dav1dde merged 1 commit into
mainfrom
dav1d/remove-internal

Conversation

@Dav1dde

@Dav1dde Dav1dde commented Nov 3, 2025

Copy link
Copy Markdown
Member

Description

As discussed, sentry._internal should be reserved for the EAP data model, when converting from a span/log/.. to EAP, not for actual attributes.

In a future change, we'll introduce a way to hide attributes.

PR Checklist

  • I have run yarn test and verified that the tests pass.
  • I have run yarn generate && yarn format to generate and format code and docs.

If an attribute was added:

  • The attribute is in a namespace (e.g. nextjs.function_id, not function_id)
  • I've used the sentry._internal namespace if the attribute should not be visibile to end-users
  • I have used the correct value for pii (i.e. maybe or true. Use false only for values that should never be scrubbed such as IDs)

If an attribute was deprecated:

@Dav1dde
Dav1dde force-pushed the dav1d/remove-internal branch from e6de03d to 293eddf Compare November 3, 2025 11:44
@Dav1dde
Dav1dde merged commit 5cb2bb6 into main Nov 3, 2025
9 checks passed
@Dav1dde
Dav1dde deleted the dav1d/remove-internal branch November 3, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants