ref: Undeprecate sentry.observed_timestamp_nanos - #174
Conversation
|
How can we make sure this is not displayed to the user? Can't we update the places it's used? |
This is already actively displayed and already actively added to (OTeL) Spans, Logs and Trace Metrics. The UI even uses it show some sort of ingestion delay iirc. Also if this is not desired (which it very well may be), it does not represent the status quo. I think it is better to have conventions which represent the current state rather than a desired state nobody is working towards. If the attribute should be 'internal' then also somebody should be actively working on the migration of the product(s). I asked Sebastian to represent the status quo, as I assumed there is no one actively working on that migration, is this not the case? |
|
The conventions very well were launched for a desired end stated, we just got into a habit of adding more and more stuff. Anyways, if it unblocks stuff, we can merge this, but we apparently need a high level convo about this. |
I think it's just on a hover and renamed to something reasonable. This just highlights a fundamental issue, maybe we shouldn't tie to the visibility (frontend state) to the attribute name, but instead track that separately as metadata for an attribute. If for changing the visibility state we have to change ingestion and backfilll for 90 days, that seems pretty bad. This also came up recently, where we may want to track frontend aliasing also in the conventions. |
#137 added `sentry.observed_timestamp_nanos` as a deprecated attribute and `sentry._internal.observed_timestamp_nanos` as its non-deprecated replacement. However, adding the attribute as deprecated was probably a mistake because it is in active use and no concrete plan was made for a migration to the `_internal` version. It's also questionable whether this attribute should be hidden from users in the first place. Since the `_internal` version is not used anywhere and not written by Relay, I propose that we delete it and mark the non-`_internal` version as not deprecated.
e1561e7 to
0669ce9
Compare
3 participants
Description
#137 added
sentry.observed_timestamp_nanosas a deprecated attribute andsentry._internal.observed_timestamp_nanosas its non-deprecated replacement. However, adding the attribute as deprecated was probably a mistake because it is in active use and no concrete plan was made for a migration to the_internalversion. It's also questionable whether this attribute should be hidden from users in the first place.Since the
_internalversion is not used anywhere and not written by Relay, I propose that we delete it and mark the non-_internalversion as not deprecated.PR Checklist
yarn testand verified that the tests pass.yarn generate && yarn formatto generate and format code and docs.