sentry.exclusive_time milliseconds - #160
Merged
Merged
Conversation
jjbayer
commented
Sep 26, 2025
| "key": "sentry.exclusive_time", | ||
| "brief": "The exclusive time duration of the span.", | ||
| "type": "integer", | ||
| "brief": "The exclusive time duration of the span in milliseconds.", |
Member
Author
There was a problem hiding this comment.
This is open for debate. Relay / sentry currently write floating point milliseconds for exclusive time. But do we want to enforce a standard that time attributes need to be seconds unless specified explicitly in the name (e.g. _ms, _nano)?
jjbayer
marked this pull request as ready for review
September 26, 2025 09:22
jjbayer
requested review from
AbhiPrasad,
cleptric and
lcian
as code owners
September 26, 2025 09:22
cleptric
approved these changes
Oct 20, 2025
Member
|
@jjbayer If this is ready to merge, please also run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.