feat(sentry): Add sentry.observed_timestamp_nanos - #137
Merged
Conversation
loewenheim
requested review from
AbhiPrasad,
cleptric and
lcian
as code owners
September 11, 2025 13:14
Member
|
|
Contributor
Author
|
The |
Member
|
Then lets add it as deprecated and point to |
This attribute is added by Relay based on the time an envelope is received.
loewenheim
force-pushed
the
sebastian/sentry-observed-timestamp-nanos
branch
2 times, most recently
from
September 16, 2025 12:31
32b4160 to
ad29b7e
Compare
Contributor
Author
|
I've added the attribute both with and without the |
lcian
approved these changes
Sep 17, 2025
loewenheim
added a commit
that referenced
this pull request
Oct 20, 2025
#137 added `sentry.observed_timestamp_nanos` as a deprecated attribute and `sentry._internal.observed_timestamp_nanos` as its non-deprecated replacement. However, adding the attribute as deprecated was probably a mistake because it is in active use and no concrete plan was made for a migration to the `_internal` version. It's also questionable whether this attribute should be hidden from users in the first place. Since the `_internal` version is not used anywhere and not written by Relay, I propose that we delete it and mark the non-`_internal` version as not deprecated.
2 tasks
loewenheim
added a commit
that referenced
this pull request
Oct 29, 2025
#137 added `sentry.observed_timestamp_nanos` as a deprecated attribute and `sentry._internal.observed_timestamp_nanos` as its non-deprecated replacement. However, adding the attribute as deprecated was probably a mistake because it is in active use and no concrete plan was made for a migration to the `_internal` version. It's also questionable whether this attribute should be hidden from users in the first place. Since the `_internal` version is not used anywhere and not written by Relay, I propose that we delete it and mark the non-`_internal` version as not deprecated.
loewenheim
added a commit
that referenced
this pull request
Oct 29, 2025
#137 added `sentry.observed_timestamp_nanos` as a deprecated attribute and `sentry._internal.observed_timestamp_nanos` as its non-deprecated replacement. However, adding the attribute as deprecated was probably a mistake because it is in active use and no concrete plan was made for a migration to the `_internal` version. It's also questionable whether this attribute should be hidden from users in the first place. Since the `_internal` version is not used anywhere and not written by Relay, I propose that we delete it and mark the non-`_internal` version as not deprecated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attribute is added by Relay based on the time an envelope is received.
Closes INGEST-573.