feat: Add sendDefaultPii to SentryOptions #923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add sendDefaultPii to SentryOptions. When enabled, the SDK sends personal identifiable along with events. Currently, that only applies to the IP address of the user. Fixes GH-910
marandaneto
reviewed
Jan 29, 2021
Codecov Report
@@ Coverage Diff @@
## master #923 +/- ##
==========================================
+ Coverage 94.68% 94.74% +0.06%
==========================================
Files 76 76
Lines 3497 3504 +7
==========================================
+ Hits 3311 3320 +9
+ Misses 186 184 -2
Continue to review full report at Codecov.
|
marandaneto
approved these changes
Jan 29, 2021
philipphofmann
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Feb 1, 2021
We added this for Apple recently, see getsentry/sentry-cocoa#923.
philipphofmann
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Feb 22, 2021
We added this for Apple recently, see getsentry/sentry-cocoa#923.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Add sendDefaultPii to SentryOptions. When enabled, the SDK sends personal identifiable along with
events. Currently, that only applies to the IP address of the user.
💡 Motivation and Context
Fixes GH-910
💚 How did you test it?
📝 Checklist
🔮 Next steps
Update the docs.