chore: Remove V9 SDK API scripts and fixed project references#7089
chore: Remove V9 SDK API scripts and fixed project references#7089
Conversation
philprime
requested review from
itaybre,
noahsmartin and
philipphofmann
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## v8.x #7089 +/- ##
=============================================
- Coverage 85.981% 7.322% -78.659%
=============================================
Files 440 405 -35
Lines 27506 26274 -1232
Branches 11893 9514 -2379
=============================================
- Hits 23650 1924 -21726
- Misses 3813 24339 +20526
+ Partials 43 11 -32 see 424 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
Thanks a lot. When CI is green, LGTM
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 653de7c | 1205.02 ms | 1222.20 ms | 17.18 ms |
| f73c5c8 | 1211.10 ms | 1234.62 ms | 23.51 ms |
| 3af1ae9 | 1225.60 ms | 1252.65 ms | 27.05 ms |
| c21a31f | 1237.04 ms | 1256.65 ms | 19.61 ms |
| 237dfb1 | 1214.90 ms | 1258.63 ms | 43.73 ms |
| c21a31f | 1216.02 ms | 1236.34 ms | 20.32 ms |
| 5e3fb04 | 1239.84 ms | 1267.39 ms | 27.55 ms |
| b66be9b | 1218.22 ms | 1244.19 ms | 25.96 ms |
| e537c90 | 1226.22 ms | 1256.64 ms | 30.41 ms |
| ab82dac | 1249.73 ms | 1272.69 ms | 22.96 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 653de7c | 23.75 KiB | 992.25 KiB | 968.50 KiB |
| f73c5c8 | 24.14 KiB | 1001.32 KiB | 977.18 KiB |
| 3af1ae9 | 23.74 KiB | 981.29 KiB | 957.55 KiB |
| c21a31f | 23.75 KiB | 1000.77 KiB | 977.02 KiB |
| 237dfb1 | 23.75 KiB | 1000.79 KiB | 977.04 KiB |
| c21a31f | 23.75 KiB | 1000.80 KiB | 977.05 KiB |
| 5e3fb04 | 23.74 KiB | 981.30 KiB | 957.56 KiB |
| b66be9b | 23.75 KiB | 996.03 KiB | 972.28 KiB |
| e537c90 | 23.75 KiB | 992.03 KiB | 968.28 KiB |
| ab82dac | 23.75 KiB | 991.85 KiB | 968.10 KiB |
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
3 participants
sdk_api_v9.jsonwhich is not needed on thev8.xbranch anymore#skip-changelog
Closes #7090