Conversation
…ly casting to UISplitViewController
philprime
requested review from
itaybre,
noahsmartin and
philipphofmann
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v8.x #6771 +/- ##
=============================================
- Coverage 86.118% 86.050% -0.068%
=============================================
Files 441 441
Lines 27591 27600 +9
Branches 11958 11959 +1
=============================================
- Hits 23761 23750 -11
- Misses 3786 3806 +20
Partials 44 44
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…me/uiprintpanel-sdk-crash
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c21a31f | 1237.04 ms | 1256.65 ms | 19.61 ms |
| 653de7c | 1205.02 ms | 1222.20 ms | 17.18 ms |
| 3af1ae9 | 1225.60 ms | 1252.65 ms | 27.05 ms |
| 41834f1 | 1235.15 ms | 1256.31 ms | 21.17 ms |
| 5e3fb04 | 1239.84 ms | 1267.39 ms | 27.55 ms |
| b66be9b | 1218.22 ms | 1244.19 ms | 25.96 ms |
| 5fce94f | 1226.31 ms | 1246.82 ms | 20.50 ms |
| c21a31f | 1216.02 ms | 1236.34 ms | 20.32 ms |
| 237dfb1 | 1214.90 ms | 1258.63 ms | 43.73 ms |
| f76f6bf | 1207.70 ms | 1233.27 ms | 25.57 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c21a31f | 23.75 KiB | 1000.77 KiB | 977.02 KiB |
| 653de7c | 23.75 KiB | 992.25 KiB | 968.50 KiB |
| 3af1ae9 | 23.74 KiB | 981.29 KiB | 957.55 KiB |
| 41834f1 | 23.75 KiB | 991.88 KiB | 968.13 KiB |
| 5e3fb04 | 23.74 KiB | 981.30 KiB | 957.56 KiB |
| b66be9b | 23.75 KiB | 996.03 KiB | 972.28 KiB |
| 5fce94f | 23.75 KiB | 991.62 KiB | 967.87 KiB |
| c21a31f | 23.75 KiB | 1000.80 KiB | 977.05 KiB |
| 237dfb1 | 23.75 KiB | 1000.79 KiB | 977.04 KiB |
| f76f6bf | 23.74 KiB | 981.30 KiB | 957.56 KiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
The internal class of
UIPrintPanelViewControllerseems to override theisKindOfClass:method, therefore wrongfully casting to aUISplitViewControlleron iOS 26+.This PR checks if the instance actually responds to
viewControllersto resolve the error.💡 Motivation and Context
See #6725 for full investigation information
Closes #6725