fix: Remove full sentry being included when using SentryWithoutUIKit#6754
Merged
fix: Remove full sentry being included when using SentryWithoutUIKit#6754
Conversation
itaybre
requested review from
noahsmartin,
philipphofmann and
philprime
as code owners
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c122943 | 1210.94 ms | 1233.78 ms | 22.84 ms |
| 8bb3e37 | 1235.18 ms | 1252.63 ms | 17.45 ms |
| 2b02431 | 1229.63 ms | 1248.98 ms | 19.35 ms |
| 3319d58 | 1226.46 ms | 1256.56 ms | 30.10 ms |
| 079bcc8 | 1217.88 ms | 1234.88 ms | 17.00 ms |
| 650d802 | 1231.86 ms | 1255.64 ms | 23.78 ms |
| cb07a0e | 1217.47 ms | 1251.94 ms | 34.47 ms |
| 83d27f6 | 1233.56 ms | 1259.24 ms | 25.68 ms |
| be6a4ee | 1226.33 ms | 1249.77 ms | 23.44 ms |
| 7148f97 | 1235.09 ms | 1258.07 ms | 22.98 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c122943 | 23.74 KiB | 926.65 KiB | 902.90 KiB |
| 8bb3e37 | 23.75 KiB | 968.25 KiB | 944.50 KiB |
| 2b02431 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| 3319d58 | 23.75 KiB | 1021.48 KiB | 997.73 KiB |
| 079bcc8 | 23.74 KiB | 874.07 KiB | 850.33 KiB |
| 650d802 | 23.74 KiB | 913.13 KiB | 889.39 KiB |
| cb07a0e | 23.75 KiB | 1.01 MiB | 1016.13 KiB |
| 83d27f6 | 23.75 KiB | 928.88 KiB | 905.13 KiB |
| be6a4ee | 23.75 KiB | 913.14 KiB | 889.39 KiB |
| 7148f97 | 23.75 KiB | 854.78 KiB | 831.03 KiB |
philipphofmann
approved these changes
Nov 12, 2025
Member
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
LGTM, so easy 🤦 thanks
Member
|
Is this something we should also merge to v8.x.x, @itaybre? |
Contributor
Author
We can do it there, it is an easy fix |
…move_sentry_dependency
itaybre
added a commit
that referenced
this pull request
Nov 12, 2025
…6754) * fix: Remove full sentry being included when using SentryWithoutUIKit * Update changelog * Add PR number to Changelog * Update changelog * Fix changelog
itaybre
added a commit
that referenced
this pull request
Nov 13, 2025
…utUIKit (#6761) * fix: Remove full sentry being included when using SentryWithoutUIKit (#6754) * fix: Remove full sentry being included when using SentryWithoutUIKit * Update changelog * Add PR number to Changelog * Update changelog * Fix changelog * Remove unnecesary changelog changes * Update CHANGELOG.md Co-authored-by: Philip Niedertscheider <[email protected]> --------- Co-authored-by: Philip Niedertscheider <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like
SentryCppHelperis depending onSentrywhich is actually not necesary.This fixes the issue.
SentryCppHelperobjective is lo add c++ to the linker, nothing else.Adding Sentry as a dependency was a mistake.
Fixes: #6696
Closes #6755