chore(tests): Remove snapshot testing to reduce repository size#6631
Merged
chore(tests): Remove snapshot testing to reduce repository size#6631
Conversation
philprime
requested review from
itaybre,
noahsmartin and
philipphofmann
as code owners
philprime
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6631 +/- ##
=============================================
+ Coverage 85.453% 85.459% +0.006%
=============================================
Files 451 451
Lines 27566 27565 -1
Branches 12069 12070 +1
=============================================
+ Hits 23556 23557 +1
+ Misses 3963 3721 -242
- Partials 47 287 +240 see 48 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 827b50c | 1233.27 ms | 1267.28 ms | 34.01 ms |
| 8745cc0 | 1228.13 ms | 1250.48 ms | 22.35 ms |
| ebc72be | 1221.24 ms | 1249.66 ms | 28.42 ms |
| 8ad303c | 1220.02 ms | 1231.79 ms | 11.77 ms |
| 331dad6 | 1210.40 ms | 1242.06 ms | 31.67 ms |
| 2bddb03 | 1214.11 ms | 1246.78 ms | 32.67 ms |
| 916edbe | 1243.86 ms | 1256.11 ms | 12.25 ms |
| 3b4b557 | 1234.59 ms | 1254.02 ms | 19.43 ms |
| b074ba9 | 1236.52 ms | 1248.75 ms | 12.23 ms |
| 25f2d2c | 1232.02 ms | 1242.78 ms | 10.76 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 827b50c | 23.75 KiB | 1.00 MiB | 1005.07 KiB |
| 8745cc0 | 23.74 KiB | 971.81 KiB | 948.07 KiB |
| ebc72be | 23.75 KiB | 908.22 KiB | 884.47 KiB |
| 8ad303c | 23.75 KiB | 879.24 KiB | 855.49 KiB |
| 331dad6 | 23.75 KiB | 928.12 KiB | 904.37 KiB |
| 2bddb03 | 23.75 KiB | 891.01 KiB | 867.26 KiB |
| 916edbe | 23.75 KiB | 908.41 KiB | 884.66 KiB |
| 3b4b557 | 23.75 KiB | 908.39 KiB | 884.64 KiB |
| b074ba9 | 23.74 KiB | 976.79 KiB | 953.05 KiB |
| 25f2d2c | 23.75 KiB | 866.69 KiB | 842.94 KiB |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
philprime
added a commit
that referenced
this pull request
Nov 5, 2025
philprime
added a commit
that referenced
this pull request
Nov 6, 2025
…in (#6678) * fix(session-replay): Update rendering method for fast view rendering (#6360) * fix(session-replay): Extend masking and focus masking on sensitive information (#6292) * test(session-replay): Add masking tests for common cases (#6567) * test(session-replay): Add masking tests for React Native views (#6568) * fix(session-replay): Fix conversion of frame rate to time interval (#6623) * test(session-replay): Add masking tests for edge cases (#6569) * test(session-replay): Add masking tests for UIKit views (#6570) * test(session-replay): Add masking tests for special views (#6571) * fix(session-replay): Include layer background color when checking if a view is opaque (#6629) * chore(tests): Remove snapshot testing to reduce repository size (#6631) * chore: Remove unwanted CHANGELOG entries from cherry-pick - Remove #5591 (minimum OS version warnings) - not related to session replay - Remove #6019 (SCNetworkReachability) - not related to session replay - Remove #6377 (thread event issue) - not related to session replay - Remove #6381 (frame delay) - duplicate/not related to session replay - Keep only session replay masking related changes * docs: Move changelog changes from v8.57.1 to unreleased * test: Resolve wrong assertions involed due to merge-conflict * chore: Update sdk_api_V9.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes snapshot tests introduced in session replay masking PRs.
The reason is that Swift Package Manager requires a deep clone and we should not further bloat the repository with assets, unless necessary.
We might consider using EmergeTools Snapshots at some point in the near future and partially revert this commit.
#skip-changelog
Closes #6632