Conversation
Ensure that the test server is running with a retry mechanism to avoid flakiness in CI.
Add decision log entry for v8 branch and explain how to release from it.
The SDK reported false frame delay statistics when it moved from the background to the foreground, which also led to falsely reported app hangs. Fixes GH-6345
* fix: Fix crash when last replay info is missing keys * Update changelog
…afe (#6573) * fix: Disable SessionSentryReplayIntegration if the environment is unsafe * Simplify shouldEnableSessionReplay * Rename test * Add log message * Update changelog * Safely unwrap SentryOptions
itaybre
requested review from
noahsmartin,
philipphofmann and
philprime
as code owners
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
philprime
approved these changes
Oct 30, 2025
Member
philprime
left a comment
philprime
left a comment
There was a problem hiding this comment.
LGTM but CI must be green.
It might be easier to branch from v8-x into a temporary branch which is updated with changes on main, then merging the temp branch into main
Contributor
Author
Yeah, that's what I did, but had some issues during the merge. |
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 52603c5 | 1226.94 ms | 1257.66 ms | 30.72 ms |
| 83e9b16 | 1223.25 ms | 1250.94 ms | 27.69 ms |
| cd9727b | 1236.04 ms | 1254.41 ms | 18.37 ms |
| fc0757d | 1231.83 ms | 1248.98 ms | 17.15 ms |
| b714cb9 | 1224.71 ms | 1238.04 ms | 13.33 ms |
| 25f4532 | 1203.28 ms | 1240.71 ms | 37.44 ms |
| 2ca8f2e | 1207.08 ms | 1235.58 ms | 28.49 ms |
| 018037b | 1209.31 ms | 1228.33 ms | 19.03 ms |
| 924de23 | 1222.84 ms | 1248.37 ms | 25.54 ms |
| 09471ff | 1239.98 ms | 1256.65 ms | 16.67 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 52603c5 | 23.75 KiB | 969.78 KiB | 946.03 KiB |
| 83e9b16 | 23.75 KiB | 947.72 KiB | 923.97 KiB |
| cd9727b | 23.75 KiB | 879.25 KiB | 855.51 KiB |
| fc0757d | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| b714cb9 | 23.75 KiB | 858.69 KiB | 834.93 KiB |
| 25f4532 | 23.75 KiB | 969.27 KiB | 945.52 KiB |
| 2ca8f2e | 23.74 KiB | 996.96 KiB | 973.21 KiB |
| 018037b | 23.75 KiB | 867.16 KiB | 843.41 KiB |
| 924de23 | 23.75 KiB | 947.54 KiB | 923.79 KiB |
| 09471ff | 23.75 KiB | 990.16 KiB | 966.41 KiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6610