chore: Merge hotfix changes from v8.57.0 into main#6419
Merged
Conversation
philprime
force-pushed
the
philprime/v8.x-cleaned
branch
from
642ddf8 to
b3952ce
Compare
(cherry picked from commit e9bcb13)
philprime
changed the title
philprime
requested review from
itaybre,
noahsmartin and
philipphofmann
as code owners
philipphofmann
approved these changes
Oct 14, 2025
Member
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
Thanks, LGTM when CI is green.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6419 +/- ##
========================================
Coverage ? 86.895%
========================================
Files ? 445
Lines ? 37505
Branches ? 17447
========================================
Hits ? 32590
Misses ? 4870
Partials ? 45
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Pull Request Overview
This PR merges hotfix changes from v8.57.0 into main to address critical PII leaks in Session Replay on iOS 26 with Liquid Glass rendering. The changes add defensive programming to automatically disable Session Replay in unreliable environments unless explicitly overridden.
- Adds environment checking to detect iOS 26+ with Xcode 26+ builds that may cause masking failures
- Introduces experimental option to override the automatic disabling in unreliable environments
- Updates version numbers across all configuration files and package manifests
Reviewed Changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk_api.json | Adds new experimental option API definition |
| Sources/Swift/SentryExperimentalOptions.swift | Defines enableSessionReplayInUnreliableEnvironment flag |
| Sources/Swift/Integrations/SessionReplay/SentrySessionReplay.swift | Implements environment checking and conditional disabling |
| Sources/Swift/Integrations/SessionReplay/SentrySessionReplayEnvironmentChecker.swift | Core logic for detecting unreliable environments |
| Sources/Swift/Helper/InfoPlist/*.swift | New utilities for reading Info.plist values |
| Tests/**/*.swift | Comprehensive test coverage for new functionality |
| Configuration files | Version bumps to 8.57.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Tests/SentryTests/Integrations/SessionReplay/SentrySessionReplayTests.swift
Show resolved
Hide resolved
Sources/Swift/Integrations/SessionReplay/SentrySessionReplayEnvironmentChecker.swift
Show resolved
Hide resolved
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e3767a1 | 1224.20 ms | 1257.16 ms | 32.96 ms |
| b115f82 | 1212.96 ms | 1251.92 ms | 38.96 ms |
| 438caec | 1230.02 ms | 1250.00 ms | 19.98 ms |
| 7d23639 | 1237.93 ms | 1243.04 ms | 5.11 ms |
| e64d3d4 | 1241.90 ms | 1260.10 ms | 18.20 ms |
| 5200f5b | 1231.73 ms | 1254.35 ms | 22.62 ms |
| 701acf0 | 1230.24 ms | 1255.60 ms | 25.36 ms |
| 2675d3c | 1218.94 ms | 1239.36 ms | 20.42 ms |
| 80538ca | 1216.70 ms | 1253.92 ms | 37.22 ms |
| 884b224 | 1233.41 ms | 1259.50 ms | 26.09 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e3767a1 | 23.75 KiB | 913.14 KiB | 889.39 KiB |
| b115f82 | 23.75 KiB | 989.04 KiB | 965.30 KiB |
| 438caec | 23.74 KiB | 913.14 KiB | 889.40 KiB |
| 7d23639 | 23.75 KiB | 891.01 KiB | 867.26 KiB |
| e64d3d4 | 23.75 KiB | 855.37 KiB | 831.62 KiB |
| 5200f5b | 23.75 KiB | 933.33 KiB | 909.58 KiB |
| 701acf0 | 23.75 KiB | 987.96 KiB | 964.21 KiB |
| 2675d3c | 23.75 KiB | 928.16 KiB | 904.41 KiB |
| 80538ca | 23.75 KiB | 989.99 KiB | 966.24 KiB |
| 884b224 | 23.75 KiB | 879.60 KiB | 855.86 KiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges changes released on the hotfix branch to main.
#skip-changelog
Closes #6420