fix(v8): Wrong Frame Delay when becoming active (#6381)#6393
Merged
philipphofmann merged 1 commit intov8.xfrom Oct 13, 2025
Merged
fix(v8): Wrong Frame Delay when becoming active (#6381)#6393philipphofmann merged 1 commit intov8.xfrom
philipphofmann merged 1 commit intov8.xfrom
Conversation
philipphofmann
requested review from
itaybre,
noahsmartin and
philprime
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v8.x #6393 +/- ##
=============================================
+ Coverage 86.732% 86.757% +0.025%
=============================================
Files 437 437
Lines 37158 37162 +4
Branches 17395 17392 -3
=============================================
+ Hits 32228 32241 +13
+ Misses 4885 4875 -10
- Partials 45 46 +1
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c6afcc7 | 1224.31 ms | 1256.22 ms | 31.92 ms |
| a7a0a2b | 1218.61 ms | 1248.69 ms | 30.08 ms |
| f76f6bf | 1207.70 ms | 1233.27 ms | 25.57 ms |
| b66be9b | 1218.22 ms | 1244.19 ms | 25.96 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c6afcc7 | 23.75 KiB | 996.03 KiB | 972.28 KiB |
| a7a0a2b | 23.75 KiB | 996.04 KiB | 972.29 KiB |
| f76f6bf | 23.74 KiB | 981.30 KiB | 957.56 KiB |
| b66be9b | 23.75 KiB | 996.03 KiB | 972.28 KiB |
philipphofmann
changed the title
philipphofmann
force-pushed
the
fix/app-hang-v8
branch
from
614e59b to
61ecfd1
Compare
The SDK reported false frame delay statistics when it moved from the background to the foreground, which also led to falsely reported app hangs. Fixes GH-6345
philipphofmann
force-pushed
the
fix/app-hang-v8
branch
from
61ecfd1 to
070b43a
Compare
philprime
approved these changes
Oct 13, 2025
itaybre
added a commit
that referenced
this pull request
Oct 30, 2025
* test: Ensure test is server running (#6300) Ensure that the test server is running with a retry mechanism to avoid flakiness in CI. * ci: Add v8.x branch to workflows (#6321) * chore: Explain v8 branch (#6323) Add decision log entry for v8 branch and explain how to release from it. * ci(v8): Bump Xcode from 26.0 to 26.0.1 (#6394) * docs: Add note to README with reference to v9 on main branch (#6402) * fix: Wrong Frame Delay when becoming active (#6393) The SDK reported false frame delay statistics when it moved from the background to the foreground, which also led to falsely reported app hangs. Fixes GH-6345 * fix(session-replay): Add detection for potential PII leaks disabling session replay (#6389) * release: 8.57.0 * chore: Bump simulators to 26.1 (#6578) * fix: Fix crash when last replay info is missing some keys (#6577) * fix: Fix crash when last replay info is missing keys * Update changelog * fix: Disable SessionSentryReplayIntegration if the environment is unsafe (#6573) * fix: Disable SessionSentryReplayIntegration if the environment is unsafe * Simplify shouldEnableSessionReplay * Rename test * Add log message * Update changelog * Safely unwrap SentryOptions * fix: Fix UITouch background thread access in SentryTouchTracker (#6584) * release: 8.57.1 * Fix merge issues * Fix another merge issue * More merge conflicts * Add SentryThreadInspector again * Fix tests on iOS 26 * Add `enableSessionReplayInUnreliableEnvironment` --------- Co-authored-by: Philipp Hofmann <[email protected]> Co-authored-by: Philip Niedertscheider <[email protected]> Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in this PR #6381 are already approved and merged to main. This is for V8.
We have to merge #6394 before this PR as it fixes broken unit tests.