ci: Only run test server on macOS#6350
Merged
philipphofmann merged 3 commits intomainfrom Oct 7, 2025
Merged
Conversation
The test server tests on iOS are very flaky. Let's only run these on macOS.
philipphofmann
requested review from
itaybre,
noahsmartin and
philprime
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6350 +/- ##
=============================================
+ Coverage 86.818% 86.834% +0.016%
=============================================
Files 438 438
Lines 37311 37311
Branches 17428 17429 +1
=============================================
+ Hits 32393 32399 +6
+ Misses 4874 4867 -7
- Partials 44 45 +1 see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
philprime
reviewed
Oct 6, 2025
noahsmartin
approved these changes
Oct 6, 2025
Contributor
noahsmartin
left a comment
noahsmartin
left a comment
There was a problem hiding this comment.
LGTM with the suggestion that we should leave it commented out with a link to an issue tracking it
philipphofmann
added a commit
that referenced
this pull request
Oct 8, 2025
The test server tests on iOS are very flaky. Let's only run these on macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test server tests on iOS are very flaky. Let's only run these on macOS, as they didn't fail there in the last two weeks.
Perhaps that's because the simulator has difficulty communicating with a running test server in CI.
#skip-changelog
Closes #6351