Skip to content

Comments

fix: Fix xcode 26#5386

Merged
noahsmartin merged 1 commit intomainfrom
supportNewXcode
Jun 11, 2025
Merged

fix: Fix xcode 26#5386
noahsmartin merged 1 commit intomainfrom
supportNewXcode

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Jun 9, 2025 •
edited
Loading

📜 Description

Fix for Xcode 26

💡 Motivation and Context

Fixes this error in Xcode 26:
Screenshot 2025-06-09 at 1 09 58 PM

💚 How did you test it?

Build with xcode

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@codecov
Copy link

codecov bot commented Jun 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.075%. Comparing base (355780b) to head (12264b3).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5386       +/-   ##
=============================================
+ Coverage   86.030%   86.075%   +0.045%     
=============================================
  Files          397       397               
  Lines        34596     34594        -2     
  Branches     14985     14979        -6     
=============================================
+ Hits         29763     29777       +14     
+ Misses        4786      4777        -9     
+ Partials        47        40        -7
Files with missing lines Coverage Δ
...Crash/Recording/Tools/SentryCrashCxaThrowSwapper.c 88.446% <100.000%> (ø)
...yCrash/Recording/Tools/SentryCrashMachineContext.h 100.000% <100.000%> (ø)
.../Recording/Tools/SentryCrashMachineContext_Apple.h 100.000% <ø> (ø)

... and 15 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 355780b...12264b3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1205.12 ms 1248.27 ms 43.14 ms
Size 23.75 KiB 846.54 KiB 822.79 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c45c91c 1222.90 ms 1225.75 ms 2.85 ms
e89dc54 1220.57 ms 1233.45 ms 12.88 ms
024f3db 1228.08 ms 1246.55 ms 18.47 ms
c6773e5 1222.48 ms 1240.02 ms 17.54 ms
0559a8f 1212.37 ms 1232.12 ms 19.76 ms
b15521e 1224.44 ms 1251.13 ms 26.68 ms
9798947 1224.06 ms 1238.90 ms 14.84 ms
6001822 1233.31 ms 1251.64 ms 18.33 ms
4efc7da 1235.39 ms 1256.57 ms 21.18 ms
8fb1a4a 1225.73 ms 1251.48 ms 25.74 ms

App size

Revision Plain With Sentry Diff
c45c91c 21.58 KiB 714.29 KiB 692.71 KiB
e89dc54 22.85 KiB 412.60 KiB 389.75 KiB
024f3db 21.90 KiB 725.67 KiB 703.76 KiB
c6773e5 20.76 KiB 435.25 KiB 414.49 KiB
0559a8f 21.58 KiB 419.81 KiB 398.22 KiB
b15521e 21.58 KiB 573.18 KiB 551.60 KiB
9798947 22.31 KiB 821.95 KiB 799.64 KiB
6001822 22.85 KiB 410.99 KiB 388.14 KiB
4efc7da 22.31 KiB 765.80 KiB 743.48 KiB
8fb1a4a 21.90 KiB 727.76 KiB 705.86 KiB

Previous results on branch: supportNewXcode

Startup times

Revision Plain With Sentry Diff
c42d5d0 1237.02 ms 1270.04 ms 33.02 ms

App size

Revision Plain With Sentry Diff
c42d5d0 23.75 KiB 841.01 KiB 817.27 KiB

philprime
philprime approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've touched the sentrycrashmc_contextSize a couple of times in recent weeks/months. It would be great to have a comment in the code to share additional context why this is done using a macro instead of a const int, so we when revisiting it again we do not have to find this PR first.

Leaving this to you.

armcknight
armcknight approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@armcknight armcknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I don't think this warrants a comment in the code. If people are interested in how the code has evolved they can find their way back to this PR with git blame.

@noahsmartin I originally asked you to verify a crash before and after this change but looking again I don't think that is really even necessary.

@noahsmartin noahsmartin merged commit 410aca5 into main Jun 11, 2025
134 of 137 checks passed
@noahsmartin noahsmartin deleted the supportNewXcode branch June 11, 2025 18:26
philprime pushed a commit that referenced this pull request Jun 13, 2025
@noahsmartin @philprime
fix: Fix xcode 26 (#5386)
4a4601c
@antonis antonis mentioned this pull request Jun 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itaybre itaybre itaybre approved these changes

@armcknight armcknight armcknight approved these changes

@philprime philprime philprime approved these changes

@philipphofmann philipphofmann Awaiting requested review from philipphofmann philipphofmann is a code owner

@trevor-e trevor-e Awaiting requested review from trevor-e

@NicoHinderling NicoHinderling Awaiting requested review from NicoHinderling

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@noahsmartin @itaybre @armcknight @philprime