fix(profiling): Change path of non-sandboxed macOS app launch profile configuration#5143
Conversation
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## hotfix/8.49.2 #5143 +/- ##
=================================================
Coverage ? 92.798%
=================================================
Files ? 676
Lines ? 84024
Branches ? 30583
=================================================
Hits ? 77973
Misses ? 5950
Partials ? 101
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dfab59c | 1240.43 ms | 1259.83 ms | 19.40 ms |
| 0ac3953 | 1212.67 ms | 1236.52 ms | 23.85 ms |
| 987aede | 1218.45 ms | 1240.68 ms | 22.23 ms |
| f699e3c | 1203.06 ms | 1238.67 ms | 35.61 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dfab59c | 22.30 KiB | 851.81 KiB | 829.51 KiB |
| 0ac3953 | 22.30 KiB | 851.81 KiB | 829.50 KiB |
| 987aede | 22.30 KiB | 851.81 KiB | 829.51 KiB |
| f699e3c | 22.31 KiB | 851.81 KiB | 829.51 KiB |
|
I went ahead and fixed the paths to the Entitlements, as they were incorrect on my case-sensitive file-system. |
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
5 similar comments
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
…xcept for bundle id
…to deploy both apps
…ue to codesign errors, trying to fix)
c7a2fe0 to
219b35c
Compare
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
armcknight
changed the title
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
philprime
changed the title
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
philprime
left a comment
philprime
left a comment
There was a problem hiding this comment.
LGTM, still need wait for green CI
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
I only looked at the changelog and the actual fix but not at the sample apps. I trust @philprime s review.
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
3 participants
reproduces the issue reported in #5142 and fixed in #5144
This extends the macOS-Swift project to have four app targets: two that are sandboxed, and two that are not.
This allows us to simulate the scenario where one mac app configures launch profiling thus writing the launch profile config file, and then a different app with a different bundle id tries to configure the SDK to never profile launches, but then still reads the config file from the common cache location and has the profiler run when it shouldn't.
The simulation runs the same way for each pair of apps (sandboxed and nonsandboxed). Only the nonsandboxed pair test should fail, since the sandboxed pair gets an automatically namespaced caches path.
#skip-changelog