Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4358 +/- ##
=============================================
+ Coverage 91.426% 91.465% +0.038%
=============================================
Files 630 631 +1
Lines 50668 50780 +112
Branches 18296 18406 +110
=============================================
+ Hits 46324 46446 +122
+ Misses 4252 4242 -10
Partials 92 92
... and 21 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f4e0299 | 1230.33 ms | 1249.68 ms | 19.35 ms |
| 2a894d5 | 1202.07 ms | 1227.66 ms | 25.59 ms |
| 9f0d9e0 | 1206.55 ms | 1219.41 ms | 12.86 ms |
| 8cf5bca | 1212.35 ms | 1223.90 ms | 11.54 ms |
| 3a31fc9 | 1237.35 ms | 1249.02 ms | 11.67 ms |
| 984eb2d | 1220.62 ms | 1235.24 ms | 14.62 ms |
| c471221 | 1224.16 ms | 1241.59 ms | 17.43 ms |
| 156e771 | 1228.06 ms | 1242.64 ms | 14.58 ms |
| de033da | 1216.91 ms | 1222.84 ms | 5.92 ms |
| f1c36e0 | 1215.18 ms | 1223.62 ms | 8.43 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f4e0299 | 20.76 KiB | 427.54 KiB | 406.78 KiB |
| 2a894d5 | 21.58 KiB | 414.57 KiB | 392.99 KiB |
| 9f0d9e0 | 21.58 KiB | 424.28 KiB | 402.70 KiB |
| 8cf5bca | 21.58 KiB | 671.30 KiB | 649.72 KiB |
| 3a31fc9 | 20.76 KiB | 414.45 KiB | 393.69 KiB |
| 984eb2d | 20.76 KiB | 425.77 KiB | 405.01 KiB |
| c471221 | 22.85 KiB | 413.89 KiB | 391.04 KiB |
| 156e771 | 20.76 KiB | 419.70 KiB | 398.94 KiB |
| de033da | 21.58 KiB | 418.15 KiB | 396.57 KiB |
| f1c36e0 | 21.58 KiB | 670.40 KiB | 648.81 KiB |
brustolin
left a comment
brustolin
left a comment
There was a problem hiding this comment.
First pass, it looks good.
Just a few comments.
Co-authored-by: Dhiogo Brustolin <[email protected]>
There was a problem hiding this comment.
Thank you for reviewing @brustolin and the feedback 🙇
I applied your suggestions and it is ready for another pass.
Note that the Test / Unit iOS - Xcode 15.4 - OS 17.2 andBenchmarking / Collect app metrics CI checks are failing for me. I think they are flaky and I'll try to rerun. Let me know if you have more context since I'm new to the repo 🙏
brustolin
left a comment
brustolin
left a comment
There was a problem hiding this comment.
Thanks for this. Looks good!
|
Thank you for the review and the feedback 🙇 |
|
Thank you for adding the field. @antonis |
4 participants
📜 Description
Adds a new
SentryBreadcrumboptional private string propertyorigin💡 Motivation and Context
Fixes #4043
The discussion in getsentry/sentry-capacitor#629 (comment) adds some context on the need of a new field.
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.🔮 Next steps