feat(replay): add captureReplay without Event param for Hybrid SDKs#3878
Merged
krystofwoldrich merged 3 commits intomainfrom Apr 25, 2024
Merged
feat(replay): add captureReplay without Event param for Hybrid SDKs#3878krystofwoldrich merged 3 commits intomainfrom
captureReplay without Event param for Hybrid SDKs#3878krystofwoldrich merged 3 commits intomainfrom
Conversation
krystofwoldrich
requested review from
armcknight,
brustolin and
philipphofmann
as code owners
Contributor
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3878 +/- ##
=============================================
- Coverage 90.635% 90.609% -0.026%
=============================================
Files 579 579
Lines 45298 45313 +15
Branches 16122 16124 +2
=============================================
+ Hits 41056 41058 +2
- Misses 4063 4076 +13
Partials 179 179
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
brustolin
reviewed
Apr 23, 2024
Contributor
brustolin
left a comment
brustolin
left a comment
There was a problem hiding this comment.
Im not sure about exposing SentrySessionReplay to Hybrid SDK.
And btw, I plan to migrate this to swift.
What are the benefits of this instead of a start//stopReplay function at PrivateSentrySDKOnly?
29 tasks
Contributor
Author
|
@brustolin I tried to make minimum changes to get Replay working for RN as I know you are planning to change this class. I opened this PR to establish an interface in |
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b9a9dca | 1377.00 ms | 1382.55 ms | 5.55 ms |
| da5462e | 1198.18 ms | 1229.14 ms | 30.96 ms |
| f8833c4 | 1230.00 ms | 1245.27 ms | 15.27 ms |
| 8f397a7 | 1251.82 ms | 1268.34 ms | 16.52 ms |
| 7fb7afb | 1230.12 ms | 1251.04 ms | 20.92 ms |
| 289c0b8 | 1245.63 ms | 1253.76 ms | 8.13 ms |
| 6c31077 | 1233.80 ms | 1245.34 ms | 11.54 ms |
| b483671 | 1217.20 ms | 1236.82 ms | 19.62 ms |
| fc163f5 | 1219.18 ms | 1242.74 ms | 23.56 ms |
| 154f795 | 1225.53 ms | 1231.04 ms | 5.51 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b9a9dca | 21.58 KiB | 414.59 KiB | 393.01 KiB |
| da5462e | 22.85 KiB | 412.98 KiB | 390.13 KiB |
| f8833c4 | 21.58 KiB | 422.66 KiB | 401.08 KiB |
| 8f397a7 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
| 7fb7afb | 20.76 KiB | 419.70 KiB | 398.94 KiB |
| 289c0b8 | 22.85 KiB | 407.67 KiB | 384.82 KiB |
| 6c31077 | 22.84 KiB | 401.65 KiB | 378.81 KiB |
| b483671 | 20.76 KiB | 434.72 KiB | 413.96 KiB |
| fc163f5 | 20.76 KiB | 436.29 KiB | 415.53 KiB |
| 154f795 | 20.76 KiB | 435.25 KiB | 414.49 KiB |
brustolin
approved these changes
Apr 25, 2024
dKasabwala
pushed a commit
to dKasabwala/sentry-cocoa
that referenced
this pull request
May 6, 2024
threema-matteo
pushed a commit
to threema-ch/sentry-cocoa
that referenced
this pull request
May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits
captureReplayForEventintocaptureReplayandcaptureReplayForEvent, as Hybrid SDKs need to capture replay without passing their event to native.This PR is need for the
alpha.0of RN replay.#skip-changelog