Conversation
Contributor
|
…ing (#3638) Added SentryReplayEven, SentryReplayRecording and Envelope handling for this new types. Co-authored-by: Philipp Hofmann <[email protected]>
Settings for session replay in the Options
Handling session event during prepareEvent.
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7f691b5 | 1233.94 ms | 1243.80 ms | 9.86 ms |
| c0f08e7 | 1230.67 ms | 1246.31 ms | 15.63 ms |
| b35ccd0 | 1224.59 ms | 1241.08 ms | 16.49 ms |
| 50bb751 | 1296.52 ms | 1323.73 ms | 27.21 ms |
| 47b41ed | 1252.31 ms | 1253.96 ms | 1.64 ms |
| 42ef6ba | 1195.04 ms | 1214.35 ms | 19.31 ms |
| c00eafe | 1198.26 ms | 1227.62 ms | 29.36 ms |
| bd2afa6 | 1192.31 ms | 1210.37 ms | 18.05 ms |
| 939cd63 | 1222.53 ms | 1250.76 ms | 28.23 ms |
| c76f9b0 | 1249.78 ms | 1265.14 ms | 15.36 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7f691b5 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
| c0f08e7 | 21.58 KiB | 573.84 KiB | 552.26 KiB |
| b35ccd0 | 21.58 KiB | 573.14 KiB | 551.56 KiB |
| 50bb751 | 21.58 KiB | 417.85 KiB | 396.27 KiB |
| 47b41ed | 20.76 KiB | 436.66 KiB | 415.90 KiB |
| 42ef6ba | 21.58 KiB | 417.87 KiB | 396.28 KiB |
| c00eafe | 20.76 KiB | 432.87 KiB | 412.11 KiB |
| bd2afa6 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
| 939cd63 | 21.58 KiB | 424.35 KiB | 402.76 KiB |
| c76f9b0 | 22.85 KiB | 406.69 KiB | 383.84 KiB |
Previous results on branch: feat/session-replay
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0de47cc | 1219.55 ms | 1245.96 ms | 26.41 ms |
| 4b92944 | 1236.31 ms | 1254.06 ms | 17.76 ms |
| bfd4dba | 1219.93 ms | 1238.14 ms | 18.21 ms |
| ff24ee1 | 1234.10 ms | 1251.12 ms | 17.02 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0de47cc | 21.58 KiB | 549.65 KiB | 528.06 KiB |
| 4b92944 | 21.58 KiB | 547.02 KiB | 525.44 KiB |
| bfd4dba | 21.58 KiB | 612.11 KiB | 590.53 KiB |
| ff24ee1 | 21.58 KiB | 612.09 KiB | 590.50 KiB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3625 +/- ##
=============================================
- Coverage 90.931% 90.649% -0.282%
=============================================
Files 560 578 +18
Lines 44272 45226 +954
Branches 15776 16094 +318
=============================================
+ Hits 40257 40997 +740
- Misses 3835 4049 +214
Partials 180 180
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
29 tasks
Adding Session replay integration
Member
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
As discussed in a meeting, we will review the session replay code thoroughly after merging this PR to main. This review is only to ensure that the code in this PR doesn't impact other SDK functionality.
Co-authored-by: Philipp Hofmann <[email protected]>
…oa into feat/session-replay
…oa into feat/session-replay
philipphofmann
approved these changes
Apr 11, 2024
Member
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
Mentioning this again for the approval:
As discussed in a meeting, we will review the session replay code thoroughly after merging this PR to main. This review is only to ensure that the code in this PR doesn't impact other SDK functionality.
LGTM, but CI still complains a bit.
Co-authored-by: Philipp Hofmann <[email protected]>
…oa into feat/session-replay
dKasabwala
pushed a commit
to dKasabwala/sentry-cocoa
that referenced
this pull request
May 6, 2024
Added session replay Co-authored-by: Philipp Hofmann <[email protected]>
threema-matteo
pushed a commit
to threema-ch/sentry-cocoa
that referenced
this pull request
May 21, 2024
Added session replay Co-authored-by: Philipp Hofmann <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Added session replay
💡 Motivation and Context
Close #2616
Relates to:
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.🔮 Next steps