ref: Make allFilesInFolder internal#3592
Merged
Merged
Conversation
SentryFileManager.allFilesInFolder is only used by the SentryFileManager and can be internal. Furthermore, we can safely remove the test testAllFilesInFolder as that functionality is covered with other tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3592 +/- ##
=============================================
+ Coverage 89.275% 89.290% +0.015%
=============================================
Files 529 529
Lines 57793 57763 -30
Branches 20682 20665 -17
=============================================
- Hits 51595 51577 -18
- Misses 5174 5277 +103
+ Partials 1024 909 -115
... and 41 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a2af9fa | 1236.62 ms | 1253.12 ms | 16.50 ms |
| f25febb | 1209.08 ms | 1225.90 ms | 16.81 ms |
| 7cd187e | 1239.02 ms | 1261.42 ms | 22.40 ms |
| 9cc7e7c | 1228.90 ms | 1237.96 ms | 9.06 ms |
| 3cb68af | 1221.15 ms | 1238.40 ms | 17.25 ms |
| 881a955 | 1222.16 ms | 1237.22 ms | 15.06 ms |
| 5b6694b | 1221.71 ms | 1259.06 ms | 37.35 ms |
| 66922ca | 1221.68 ms | 1235.98 ms | 14.30 ms |
| 42ef6ba | 1195.04 ms | 1214.35 ms | 19.31 ms |
| 279841c | 1231.41 ms | 1245.65 ms | 14.24 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a2af9fa | 20.76 KiB | 432.87 KiB | 412.11 KiB |
| f25febb | 21.58 KiB | 414.92 KiB | 393.34 KiB |
| 7cd187e | 20.76 KiB | 401.65 KiB | 380.89 KiB |
| 9cc7e7c | 22.84 KiB | 403.13 KiB | 380.29 KiB |
| 3cb68af | 20.76 KiB | 401.60 KiB | 380.84 KiB |
| 881a955 | 22.85 KiB | 407.63 KiB | 384.78 KiB |
| 5b6694b | 20.76 KiB | 426.11 KiB | 405.34 KiB |
| 66922ca | 20.76 KiB | 425.80 KiB | 405.04 KiB |
| 42ef6ba | 21.58 KiB | 417.87 KiB | 396.28 KiB |
| 279841c | 22.84 KiB | 403.19 KiB | 380.35 KiB |
brustolin
approved these changes
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SentryFileManager.allFilesInFolder is only used by the SentryFileManager and can be internal. Furthermore, we can safely remove the test testAllFilesInFolder as that functionality is covered with other tests.
#skip-changelog