Add VisionOS Support for Carthage#3565
Merged
Merged
Conversation
Pre build visionOS for Carthage. Fixes GH-3410
philipphofmann
changed the title
Contributor
|
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3565 +/- ##
=============================================
+ Coverage 89.244% 89.250% +0.006%
=============================================
Files 529 529
Lines 57689 57648 -41
Branches 20641 20625 -16
=============================================
- Hits 51484 51451 -33
+ Misses 5292 5289 -3
+ Partials 913 908 -5 see 20 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4be2b3c | 1220.47 ms | 1223.88 ms | 3.41 ms |
| 8e76be4 | 1272.67 ms | 1286.38 ms | 13.71 ms |
| 1734d1b | 1198.69 ms | 1221.62 ms | 22.93 ms |
| bef2003 | 1248.18 ms | 1258.86 ms | 10.68 ms |
| 6e342ac | 1216.02 ms | 1232.88 ms | 16.86 ms |
| f797112 | 1247.41 ms | 1261.30 ms | 13.89 ms |
| e998fd0 | 1254.41 ms | 1272.78 ms | 18.37 ms |
| 98a8c16 | 1206.40 ms | 1232.14 ms | 25.74 ms |
| 1db04d8 | 1250.20 ms | 1258.12 ms | 7.92 ms |
| ed68562 | 1229.16 ms | 1248.74 ms | 19.58 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4be2b3c | 20.76 KiB | 393.37 KiB | 372.61 KiB |
| 8e76be4 | 20.76 KiB | 427.66 KiB | 406.89 KiB |
| 1734d1b | 21.58 KiB | 418.82 KiB | 397.24 KiB |
| bef2003 | 22.85 KiB | 407.73 KiB | 384.88 KiB |
| 6e342ac | 20.76 KiB | 436.66 KiB | 415.90 KiB |
| f797112 | 20.76 KiB | 434.94 KiB | 414.18 KiB |
| e998fd0 | 21.58 KiB | 414.59 KiB | 393.01 KiB |
| 98a8c16 | 20.76 KiB | 431.00 KiB | 410.24 KiB |
| 1db04d8 | 20.76 KiB | 435.50 KiB | 414.74 KiB |
| ed68562 | 22.84 KiB | 403.24 KiB | 380.39 KiB |
philipphofmann
marked this pull request as ready for review
January 22, 2024 13:36
Member
Author
|
actions/runner-images#9170 got merged. Xcode 15.2 is no longer beta see: https://github.com/actions/runner-images/blob/main/images/macos/macos-13-arm64-Readme.md. We can merge this. |
philipphofmann
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Feb 5, 2024
Related Cocoa PR getsentry/sentry-cocoa#3565.
3 tasks
philipphofmann
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Feb 6, 2024
Related Cocoa PR getsentry/sentry-cocoa#3565. Co-authored-by: vivianyentran <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix
Sources/Configuration/SDK.xcconfigby removing the workaround added with #491 so CI can build Carthage XCFrameworks to include VisionOS. The workaround seems to be fixed with Carthage/Carthage#3001 in Carthage 0.35.0 released in Jun 2020. Therefore, we can remove theSDKROOT__CARTHAGEsettings inSources/Configuration/SDK.xcconfig, which caused problems when building the SDK for visionOS see #3410 (comment). We never removed the workaround #491, as it didn't cause any problems.Furthermore, bump pre-commit action https://github.com/python-jsonschema/check-jsonschema to
0.27.3, so it allowsmacos-13-xlargeas a valid runner.Blocked by actions/runner-images#9170 to remove Xcode 15.2 beta.
Docs PR getsentry/sentry-docs#8917.
💡 Motivation and Context
Fixes GH-3410
💚 How did you test it?
CI see https://github.com/getsentry/sentry-cocoa/actions/runs/7611542267/job/20727218796.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.🔮 Next steps