feat: Add visionOS as device family#3548
Conversation
brustolin
changed the title
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Add visionOS as device family ([#3548](https://github.com/getsentry/sentry-cocoa/pull/3548))If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 26d116c | 1196.14 ms | 1209.51 ms | 13.37 ms |
| e324230 | 1252.69 ms | 1274.56 ms | 21.87 ms |
| 56ec5d0 | 1236.65 ms | 1261.90 ms | 25.25 ms |
| 7cd187e | 1243.56 ms | 1250.20 ms | 6.64 ms |
| 53a8885 | 1241.02 ms | 1270.66 ms | 29.64 ms |
| f74904f | 1229.02 ms | 1244.91 ms | 15.89 ms |
| 881a955 | 1209.47 ms | 1225.94 ms | 16.47 ms |
| 98cca71 | 1199.08 ms | 1227.36 ms | 28.28 ms |
| b9a9ffd | 1201.61 ms | 1215.06 ms | 13.45 ms |
| 3e7aa41 | 1214.02 ms | 1238.84 ms | 24.82 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 26d116c | 21.58 KiB | 417.87 KiB | 396.29 KiB |
| e324230 | 22.85 KiB | 408.87 KiB | 386.02 KiB |
| 56ec5d0 | 20.76 KiB | 414.44 KiB | 393.69 KiB |
| 7cd187e | 20.76 KiB | 401.65 KiB | 380.89 KiB |
| 53a8885 | 20.76 KiB | 434.65 KiB | 413.89 KiB |
| f74904f | 21.58 KiB | 418.71 KiB | 397.12 KiB |
| 881a955 | 22.85 KiB | 407.63 KiB | 384.78 KiB |
| 98cca71 | 22.85 KiB | 411.14 KiB | 388.29 KiB |
| b9a9ffd | 21.58 KiB | 418.43 KiB | 396.85 KiB |
| 3e7aa41 | 20.76 KiB | 432.31 KiB | 411.55 KiB |
There was a problem hiding this comment.
Following on from #3328. I think we'll also need to update a couple other things to use Xcode 15.2, some or all of these:
- ci-select-xcode.sh to use Xcode 15.2 as a default:
sentry-cocoa/scripts/ci-select-xcode.sh
Line 11 in 94d8eb3
- the build GHA workflow to build and validate the xcframework:
sentry-cocoa/.github/workflows/build.yml
Line 97 in 94d8eb3
- the unit test GHA version matrix, 14.3 is the latest Xcode version we currently use (we should also update to run iOS 17 separately once we get xcode 15.2 support; see #3329):
sentry-cocoa/.github/workflows/test.yml
Lines 110 to 114 in 94d8eb3
Yes, but I think we should create a different PR for this things. |
|
@philipphofmann do you think we can go ahead with this? |
|
|
||
| ### Features | ||
|
|
||
| - Add visionOS as device family (#3548) |
There was a problem hiding this comment.
m: This needs to move up to the unreleased section
4 participants
Added
visionOSas device family type. This will be used to filter events.