feat: Send debug meta for app start transactions#3543
Merged
Conversation
Send the complete list of debug meta for app start transactions so we can calculate statistics on the number and size of libraries loaded on the backend when the app starts. Fixes GH-3541
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3543 +/- ##
=============================================
+ Coverage 89.259% 89.279% +0.020%
=============================================
Files 528 528
Lines 57667 57723 +56
Branches 20646 20675 +29
=============================================
+ Hits 51473 51535 +62
+ Misses 5284 5275 -9
- Partials 910 913 +3
... and 21 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b8dd0fc | 1268.96 ms | 1271.90 ms | 2.94 ms |
| c76f9b0 | 1249.78 ms | 1265.14 ms | 15.36 ms |
| 60dd0f5 | 1247.35 ms | 1267.59 ms | 20.24 ms |
| 98cca71 | 1199.08 ms | 1227.36 ms | 28.28 ms |
| 438e21a | 1237.47 ms | 1255.24 ms | 17.77 ms |
| 31ac438 | 1244.29 ms | 1264.06 ms | 19.78 ms |
| 3cb68af | 1221.15 ms | 1238.40 ms | 17.25 ms |
| 9cc7e7c | 1231.84 ms | 1245.24 ms | 13.41 ms |
| 160a073 | 1260.72 ms | 1270.10 ms | 9.38 ms |
| 596ccc1 | 1230.85 ms | 1244.24 ms | 13.39 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b8dd0fc | 20.76 KiB | 401.39 KiB | 380.63 KiB |
| c76f9b0 | 22.85 KiB | 406.69 KiB | 383.84 KiB |
| 60dd0f5 | 20.76 KiB | 393.37 KiB | 372.60 KiB |
| 98cca71 | 22.85 KiB | 411.14 KiB | 388.29 KiB |
| 438e21a | 20.76 KiB | 434.62 KiB | 413.86 KiB |
| 31ac438 | 20.76 KiB | 393.36 KiB | 372.60 KiB |
| 3cb68af | 20.76 KiB | 401.60 KiB | 380.84 KiB |
| 9cc7e7c | 22.84 KiB | 403.14 KiB | 380.29 KiB |
| 160a073 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
| 596ccc1 | 22.84 KiB | 401.44 KiB | 378.60 KiB |
brustolin
approved these changes
Jan 5, 2024
philipphofmann
added a commit
that referenced
this pull request
Jan 10, 2024
Send the complete list of debug meta for app start transactions so we can calculate statistics on the number and size of libraries loaded on the backend when the app starts. Fixes GH-3541
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Send the complete list of debug meta for app start transactions so we can calculate statistics on the number and size of libraries loaded on the backend when the app starts.
💡 Motivation and Context
Fixes GH-3541
💚 How did you test it?
Unit tests and simulator.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.🔮 Next steps