feat: Prewarmed App Start Tracing is stable#3536
Merged
Merged
Conversation
Make the option enablePreWarmedAppStartTracing stable.
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3536 +/- ##
=============================================
+ Coverage 89.213% 89.258% +0.045%
=============================================
Files 528 528
Lines 57620 57638 +18
Branches 20637 20646 +9
=============================================
+ Hits 51405 51447 +42
- Misses 5185 5278 +93
+ Partials 1030 913 -117 see 35 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e681215 | 6240.94 ms | 6254.36 ms | 13.42 ms |
| 4053ee9 | 1248.04 ms | 1250.82 ms | 2.78 ms |
| 302ee8b | 1194.02 ms | 1223.34 ms | 29.32 ms |
| 25bcc50 | 1240.47 ms | 1254.70 ms | 14.23 ms |
| cce35c6 | 1228.88 ms | 1241.14 ms | 12.26 ms |
| 7bb0873 | 1226.18 ms | 1247.30 ms | 21.12 ms |
| 10ee2ce | 1250.90 ms | 1258.57 ms | 7.67 ms |
| 7bc3c0d | 1212.35 ms | 1228.94 ms | 16.59 ms |
| f587451 | 1271.63 ms | 1275.90 ms | 4.27 ms |
| d61b939 | 1238.61 ms | 1240.08 ms | 1.47 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e681215 | 20.76 KiB | 431.91 KiB | 411.15 KiB |
| 4053ee9 | 20.76 KiB | 435.22 KiB | 414.46 KiB |
| 302ee8b | 20.76 KiB | 419.62 KiB | 398.87 KiB |
| 25bcc50 | 20.76 KiB | 427.22 KiB | 406.46 KiB |
| cce35c6 | 20.76 KiB | 425.80 KiB | 405.04 KiB |
| 7bb0873 | 22.85 KiB | 407.09 KiB | 384.24 KiB |
| 10ee2ce | 20.76 KiB | 427.77 KiB | 407.00 KiB |
| 7bc3c0d | 20.76 KiB | 427.35 KiB | 406.59 KiB |
| f587451 | 20.76 KiB | 435.25 KiB | 414.49 KiB |
| d61b939 | 22.85 KiB | 407.63 KiB | 384.78 KiB |
brustolin
approved these changes
Jan 4, 2024
philipphofmann
added a commit
that referenced
this pull request
Jan 10, 2024
Make the option enablePreWarmedAppStartTracing stable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Make the option enablePreWarmedAppStartTracing stable.
Docs PR getsentry/sentry-docs#8812.
💡 Motivation and Context
The option has been in beta for over a year. We didn't hear any complaints about the feature. Let's make it stable and fix problems if required. The plan is to turn this feature on by default in the next major #3535.
💚 How did you test it?
No complaints.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.🔮 Next steps