ref: bump supported OS versions by kevinrenskers · Pull Request #2414 · getsentry/sentry-cocoa

kevinrenskers · 2022-11-21T09:00:47Z

📜 Description

Bump to macOS 10.13, iOS 11, tvOS 11, and watchOS 4

💡 Motivation and Context

Closes #1916

💚 How did you test it?

📝 Checklist

I reviewed the submitted code
I added tests to verify the changes
I updated the docs if needed
Review from the native team if needed
No breaking changes

🔮 Next steps

github-actions · 2022-11-21T09:48:06Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1226.67 ms	1241.80 ms	15.13 ms
Size	20.75 KiB	373.61 KiB	352.86 KiB

Baseline results on branch: 8.0.0

Startup times

Revision	Plain	With Sentry	Diff
`a9e77dc`	1231.94 ms	1254.85 ms	22.91 ms
`58ec104`	1244.29 ms	1269.67 ms	25.39 ms
`9be1db2`	1219.42 ms	1245.66 ms	26.24 ms
`7eee302`	1228.73 ms	1241.94 ms	13.21 ms
`dcac8ad`	1238.82 ms	1247.80 ms	8.98 ms
`d10145a`	1232.65 ms	1257.55 ms	24.90 ms
`68094b3`	1214.14 ms	1255.09 ms	40.95 ms

App size

Revision	Plain	With Sentry	Diff
`a9e77dc`	20.75 KiB	379.12 KiB	358.36 KiB
`58ec104`	20.75 KiB	379.11 KiB	358.36 KiB
`9be1db2`	20.75 KiB	373.94 KiB	353.19 KiB
`7eee302`	20.75 KiB	374.73 KiB	353.97 KiB
`dcac8ad`	20.75 KiB	379.11 KiB	358.36 KiB
`d10145a`	20.75 KiB	379.12 KiB	358.36 KiB
`68094b3`	20.75 KiB	373.94 KiB	353.19 KiB

Previous results on branch: ref/1916-bump-supported-os-versions

Startup times

Revision	Plain	With Sentry	Diff
`d011bd6`	1234.94 ms	1259.40 ms	24.46 ms
`cdc83fe`	1249.00 ms	1272.76 ms	23.76 ms
`6fc8a07`	1227.81 ms	1241.15 ms	13.34 ms
`8a69a1d`	1223.06 ms	1245.28 ms	22.22 ms
`a02bb04`	1221.02 ms	1254.24 ms	33.22 ms
`c9d27bd`	1238.88 ms	1251.52 ms	12.64 ms
`57c62e1`	1218.88 ms	1239.10 ms	20.22 ms

App size

Revision	Plain	With Sentry	Diff
`d011bd6`	20.75 KiB	373.61 KiB	352.86 KiB
`cdc83fe`	20.75 KiB	379.06 KiB	358.30 KiB
`6fc8a07`	20.75 KiB	379.05 KiB	358.30 KiB
`8a69a1d`	20.75 KiB	373.61 KiB	352.86 KiB
`a02bb04`	20.75 KiB	373.61 KiB	352.86 KiB
`c9d27bd`	20.75 KiB	379.05 KiB	358.30 KiB
`57c62e1`	20.75 KiB	373.61 KiB	352.86 KiB

kevinrenskers · 2022-11-21T10:25:25Z

I'm getting strange failures in the Sauce Labs UI Tests / Build UITests with Xcode 12.5.1 test:

❌  /Users/runner/work/sentry-cocoa/sentry-cocoa/Samples/iOS-Swift/iOS-Swift/ViewControllers/CoreDataViewController.swift:118:28: ambiguous use of 'fetchRequest()'

❌  /Users/runner/work/sentry-cocoa/sentry-cocoa/Samples/iOS-Swift/iOS-Swift/ViewControllers/CoreDataViewController.swift:121:20: cannot assign value of type '[Any]' to type '[Person]'

But also this:

[09:52:30]: There seems to be a mismatch between your provided `export_method` in gym
[09:52:30]: and the selected provisioning profiles. You passed the following options:
[09:52:30]:   export_method:      
[09:52:30]:   Bundle identifier:  io.sentry.sample.iOS-Swift
[09:52:30]:   Profile name:       match Development io.sentry.sample.iOS-Swift
[09:52:30]:   Profile type:       development
[09:52:30]: Make sure to either change the `export_method` passed from your Fastfile or CLI
[09:52:30]: or select the correct provisioning profiles by updating your Xcode project
[09:52:30]: or passing the profiles to use by using match or manually via the `export_options` hash

I haven't changed anything in CoreDataViewController.swift so I don't know why it gives these errors now? Locally it doesn't give any errors.

And I didn't change anything regarding export methods or provisioning profiles. Any ideas?

philipphofmann

That file also needs an update

sentry-cocoa/Package.swift

Line 6 in 48c7211

platforms: [.iOS(.v9), .macOS(.v10_10), .tvOS(.v9), .watchOS(.v2)],

.

philipphofmann · 2022-11-21T16:16:20Z


+### Breaking changes
+
+- Bump minimum supported OS versions: macOS 10.13, iOS 11, tvOS 11, and watchOS 4 are now supported (#2414)


Suggested change

- Bump minimum supported OS versions: macOS 10.13, iOS 11, tvOS 11, and watchOS 4 are now supported (#2414)

- Bump minimum supported OS versions to macOS 10.13, iOS 11, tvOS 11, and watchOS 4 (#2414)

philipphofmann · 2022-11-21T16:20:25Z

Any ideas?

@brustolin could maybe help.

philipphofmann · 2022-11-21T16:21:35Z

FYI, I think we don't need to update the docs yet. As long as we keep adding breaking changes to the Changelog, we can do one PR for all of that on the docs.

brustolin · 2022-11-22T08:29:02Z

We also need to update Package.swift and both .podspec.
I will take a look at this Core data error.

* 8.0.0: ref: Remove `- [SentryOptions initWithDict:didFailWithError:]` (#2404) ref: Mark [SpanProtocol setExtraValue:forKey] as deprecated (#2413) typos (#2421) test: Disable NSDataTracker in clearTestState (#2418) Update CHANGELOG.md (#2415)

kevinrenskers · 2022-11-22T09:14:17Z

We also need to update Package.swift and both .podspec.
I will take a look at this Core data error.

Done, thanks for the reminder 👍

…com/getsentry/sentry-cocoa into ref/1916-bump-supported-os-versions

philipphofmann

Why is this still a Draft PR?

philipphofmann · 2022-11-22T09:19:44Z

-  - name: "iOS-10"
-    devices:
-      - name: "iPhone.*"
-        platformVersion: "10.3.2"


👏👏👏

kevinrenskers · 2022-11-22T09:22:06Z

Why is this still a Draft PR?

Because it wasn't done yet, the tests were failing. Now it's ready.

philipphofmann

If the tests are green, LGTM.

kevinrenskers · 2022-11-22T09:37:21Z

@brustolin are all the changes you made to the VLC patch file necessary? Seems weird that the info.plist location got changed for example.

And sadly it's failing:

error: patch failed: VLC.xcodeproj/project.pbxproj:492
error: VLC.xcodeproj/project.pbxproj: patch does not apply
Error: Process completed with exit code 1.

brustolin · 2022-11-22T09:40:05Z

@brustolin are all the changes you made to the VLC patch file necessary? Seems weird that the info.plist location got changed for example.

And sadly it's failing:

The only thing I planned to change was Podfile iOS version.
I may have done something wrong here. I will fix

… found`)

Fix SPM-Dynamic

* 8.0.0: ref: Fix typos in OOMTracker (#2431) ref: Make SpanProtocol.data non nullable (#2409) ref: add/improve logging (#2420) ref: bump supported OS versions (#2414) test: shorten some tests (#2428) ref: Remove `- [SentryOptions initWithDict:didFailWithError:]` (#2404) ref: Mark [SpanProtocol setExtraValue:forKey] as deprecated (#2413) typos (#2421) test: Disable NSDataTracker in clearTestState (#2418) Update CHANGELOG.md (#2415) feat: Properly demangle Swift class name (#2162) chore: Create 8.0.0 branch test: include Sentry changes in hash keys (#2412) release: 7.31.2 fix: Crash in Client when reading integrations (#2398) test: tooling improvements (#2400) fix: Don't increase session's error count for dropped events (#2374) Update CHANGELOG.md (#2396) release: 7.31.1 Fix: Set the correct OOM event timestamp (#2394) # Conflicts: # Sentry.xcodeproj/project.pbxproj # SentryPrivate.podspec # scripts/add-sentry-to-vlc.patch

kevinrenskers added 4 commits November 21, 2022 09:59

Increase supported OS versions

2ff0f6e

Changelog

073a6a4

Increase it in more places (tests and SentryPrivate)

5510f0a

Clean up

78bf96c

Increase versions in podspec

346379f

kevinrenskers added this to the 8.0.0 milestone Nov 21, 2022

philipphofmann reviewed Nov 21, 2022

View reviewed changes

brustolin and others added 2 commits November 22, 2022 09:44

Update CoreDataViewController.swift

004bd90

brustolin added 2 commits November 22, 2022 10:15

fix tests

f1e67bc

Merge branch 'ref/1916-bump-supported-os-versions' of https://github.…

a060740

…com/getsentry/sentry-cocoa into ref/1916-bump-supported-os-versions

philipphofmann reviewed Nov 22, 2022

View reviewed changes

kevinrenskers marked this pull request as ready for review November 22, 2022 09:21

kevinrenskers requested review from armcknight and brustolin as code owners November 22, 2022 09:21

philipphofmann approved these changes Nov 22, 2022

View reviewed changes

kevinrenskers added 5 commits November 22, 2022 10:40

Remove iOS-10 suite test (was getting errors `no suite named 'iOS-10'…

02d496d

… found`)

Delete "recovered references"

0eb876f

Fix SPM-Dynamic

Reverse VLC patch file changes

261fbee

let's try this

33be17c

Let's try again

1f9ae9a

kevinrenskers merged commit 88ac2c2 into 8.0.0 Nov 22, 2022

kevinrenskers deleted the ref/1916-bump-supported-os-versions branch November 22, 2022 12:09

bnavetta mentioned this pull request May 16, 2023

Bump macOS deployment target to 10.13 warpdotdev/sentry-cocoa#3

Merged


		### Breaking changes

		- Bump minimum supported OS versions: macOS 10.13, iOS 11, tvOS 11, and watchOS 4 are now supported (#2414)

	- Bump minimum supported OS versions: macOS 10.13, iOS 11, tvOS 11, and watchOS 4 are now supported (#2414)
	- Bump minimum supported OS versions to macOS 10.13, iOS 11, tvOS 11, and watchOS 4 (#2414)

Uh oh!

Uh oh!

Conversation

kevinrenskers commented Nov 21, 2022 • edited by philipphofmann Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions Bot commented Nov 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance metrics 🚀

Baseline results on branch: 8.0.0

Startup times

App size

Previous results on branch: ref/1916-bump-supported-os-versions

Startup times

App size

Uh oh!

kevinrenskers commented Nov 21, 2022

Uh oh!

philipphofmann left a comment

Choose a reason for hiding this comment

Uh oh!

philipphofmann Nov 21, 2022

Choose a reason for hiding this comment

Uh oh!

philipphofmann commented Nov 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

philipphofmann commented Nov 21, 2022

Uh oh!

brustolin commented Nov 22, 2022

Uh oh!

kevinrenskers commented Nov 22, 2022

Uh oh!

philipphofmann left a comment

Choose a reason for hiding this comment

Uh oh!

philipphofmann Nov 22, 2022

Choose a reason for hiding this comment

Uh oh!

kevinrenskers commented Nov 22, 2022

Uh oh!

philipphofmann left a comment

Choose a reason for hiding this comment

Uh oh!

kevinrenskers commented Nov 22, 2022

Uh oh!

brustolin commented Nov 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kevinrenskers commented Nov 21, 2022 •

edited by philipphofmann

Loading

github-actions Bot commented Nov 21, 2022 •

edited

Loading

philipphofmann commented Nov 21, 2022 •

edited

Loading