Fix: Set the correct OOM event timestamp#2394
Merged
Merged
Conversation
kevinrenskers
requested review from
armcknight,
brustolin and
philipphofmann
as code owners
November 16, 2022 10:58
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 09ad77e | 1242.14 ms | 1244.02 ms | 1.88 ms |
| 6177f2d | 1206.55 ms | 1226.20 ms | 19.65 ms |
| 347a8e9 | 1243.50 ms | 1265.90 ms | 22.40 ms |
| ef8b0ce | 1212.34 ms | 1249.64 ms | 37.30 ms |
| 8607e67 | 1213.53 ms | 1238.20 ms | 24.67 ms |
| 0fdf0b2 | 1249.20 ms | 1254.08 ms | 4.88 ms |
| 5025d2e | 1245.14 ms | 1268.58 ms | 23.44 ms |
| ee127f4 | 1203.49 ms | 1231.28 ms | 27.79 ms |
| 2ce5819 | 1258.02 ms | 1271.94 ms | 13.92 ms |
| c2a9b60 | 1222.10 ms | 1240.62 ms | 18.52 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 09ad77e | 20.50 KiB | 339.01 KiB | 318.51 KiB |
| 6177f2d | 20.51 KiB | 332.90 KiB | 312.40 KiB |
| 347a8e9 | 20.51 KiB | 333.16 KiB | 312.65 KiB |
| ef8b0ce | 20.50 KiB | 337.71 KiB | 317.20 KiB |
| 8607e67 | 20.50 KiB | 338.99 KiB | 318.49 KiB |
| 0fdf0b2 | 20.51 KiB | 332.90 KiB | 312.39 KiB |
| 5025d2e | 20.51 KiB | 331.79 KiB | 311.28 KiB |
| ee127f4 | 20.51 KiB | 333.10 KiB | 312.59 KiB |
| 2ce5819 | 20.50 KiB | 337.76 KiB | 317.26 KiB |
| c2a9b60 | 20.50 KiB | 333.54 KiB | 313.04 KiB |
kevinrenskers
added a commit
that referenced
this pull request
Nov 16, 2022
…ents * master: Fix: Set the correct OOM event timestamp (#2394) test: Fix SentrySerializationTests.testSerializationFailsWithInvalidJSONObject (#2392) feat(hybrid-sdks): Add captureScreenshots to PrivateSDKOnly (#2384) ci: Increase test timeout for iOS 12 (#2391) test: Disable flaky testCrashReportCount1 (#2389) test: Disable flaky testSerializeWithUnderlyingNSException (#2387)
kevinrenskers
added a commit
that referenced
this pull request
Nov 22, 2022
* 8.0.0: ref: Fix typos in OOMTracker (#2431) ref: Make SpanProtocol.data non nullable (#2409) ref: add/improve logging (#2420) ref: bump supported OS versions (#2414) test: shorten some tests (#2428) ref: Remove `- [SentryOptions initWithDict:didFailWithError:]` (#2404) ref: Mark [SpanProtocol setExtraValue:forKey] as deprecated (#2413) typos (#2421) test: Disable NSDataTracker in clearTestState (#2418) Update CHANGELOG.md (#2415) feat: Properly demangle Swift class name (#2162) chore: Create 8.0.0 branch test: include Sentry changes in hash keys (#2412) release: 7.31.2 fix: Crash in Client when reading integrations (#2398) test: tooling improvements (#2400) fix: Don't increase session's error count for dropped events (#2374) Update CHANGELOG.md (#2396) release: 7.31.1 Fix: Set the correct OOM event timestamp (#2394) # Conflicts: # Sentry.xcodeproj/project.pbxproj # SentryPrivate.podspec # scripts/add-sentry-to-vlc.patch
kevinrenskers
added a commit
that referenced
this pull request
Nov 24, 2022
* master: (56 commits) meta: disable swiftlint file length check in TBDBClient.swift (#2435) Revert "test: shorten some tests (#2422)" (#2427) test: shorten some tests (#2422) test: include Sentry changes in hash keys (#2412) release: 7.31.2 fix: Crash in Client when reading integrations (#2398) test: tooling improvements (#2400) fix: Don't increase session's error count for dropped events (#2374) Update CHANGELOG.md (#2396) release: 7.31.1 Fix: Set the correct OOM event timestamp (#2394) test: Fix SentrySerializationTests.testSerializationFailsWithInvalidJSONObject (#2392) feat(hybrid-sdks): Add captureScreenshots to PrivateSDKOnly (#2384) ci: Increase test timeout for iOS 12 (#2391) test: Disable flaky testCrashReportCount1 (#2389) test: Disable flaky testSerializeWithUnderlyingNSException (#2387) build(deps): bump github/codeql-action from 2.1.31 to 2.1.32 (#2386) build(deps): bump fastlane from 2.210.1 to 2.211.0 (#2385) ref: json serialization error reporting (#2355) release: 7.31.0 ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Use the last breadcrumb's timestamp as the OOM event timestamp
💡 Motivation and Context
Fixes #2383
💚 How did you test it?
Unit tests, and ran the sample app, creating an OOM and waiting a few minutes before starting the app again. The OOM event has the correct timestamp: https://sentry.io/organizations/sentry-sdks/issues/2291658301/?project=5428557&query=is%3Aunresolved&referrer=issue-stream.
📝 Checklist
🔮 Next steps