ref: Fix outdated comment in SessionTracker#2381
Merged
Merged
Conversation
philipphofmann
requested review from
armcknight and
brustolin
as code owners
November 14, 2022 10:58
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5025d2e | 1248.52 ms | 1251.72 ms | 3.20 ms |
| 0fdf0b2 | 1245.88 ms | 1247.69 ms | 1.82 ms |
| b15627c | 1256.48 ms | 1264.68 ms | 8.20 ms |
| 604586a | 1216.06 ms | 1249.10 ms | 33.04 ms |
| db5f62a | 1234.47 ms | 1257.80 ms | 23.33 ms |
| 4e037c4 | 1205.00 ms | 1227.58 ms | 22.58 ms |
| 8607e67 | 1255.80 ms | 1259.50 ms | 3.70 ms |
| 46deabf | 1217.73 ms | 1247.30 ms | 29.57 ms |
| 0032a5d | 1267.35 ms | 1282.34 ms | 14.99 ms |
| 725723e | 1228.47 ms | 1255.09 ms | 26.62 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5025d2e | 20.51 KiB | 331.79 KiB | 311.28 KiB |
| 0fdf0b2 | 20.51 KiB | 332.90 KiB | 312.39 KiB |
| b15627c | 20.50 KiB | 337.76 KiB | 317.25 KiB |
| 604586a | 20.51 KiB | 333.15 KiB | 312.65 KiB |
| db5f62a | 20.51 KiB | 333.16 KiB | 312.65 KiB |
| 4e037c4 | 20.50 KiB | 361.80 KiB | 341.29 KiB |
| 8607e67 | 20.50 KiB | 338.99 KiB | 318.49 KiB |
| 46deabf | 20.75 KiB | 374.16 KiB | 353.41 KiB |
| 0032a5d | 20.75 KiB | 369.27 KiB | 348.52 KiB |
| 725723e | 20.75 KiB | 367.21 KiB | 346.46 KiB |
brustolin
approved these changes
Nov 14, 2022
kevinrenskers
added a commit
that referenced
this pull request
Nov 15, 2022
…ents * master: build(deps): bump github/codeql-action from 2.1.31 to 2.1.32 (#2386) build(deps): bump fastlane from 2.210.1 to 2.211.0 (#2385) ref: json serialization error reporting (#2355) release: 7.31.0 ref: Fix outdated comment in SessionTracker (#2381) fix: Do not delete the app state (#2382) build: Split Swift and Clang format for pre-commit (#2380)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#skip-changelog
Came up in #2150 (comment).