Skip to content

test: Fix MetricKit attachment filename#2379

Merged
philipphofmann merged 1 commit into
masterfrom
test/file-name-metric-kit
Nov 14, 2022
Merged

test: Fix MetricKit attachment filename#2379
philipphofmann merged 1 commit into
masterfrom
test/file-name-metric-kit

Conversation

@philipphofmann

@philipphofmann philipphofmann commented Nov 14, 2022

Copy link
Copy Markdown
Member

#skip-changelog

@github-actions

github-actions Bot commented Nov 14, 2022

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1239.61 ms 1262.40 ms 22.79 ms
Size 20.75 KiB 369.28 KiB 348.52 KiB

Baseline results on branch: master

Startup times

Revision Plain With Sentry Diff
4e037c4 1214.71 ms 1235.20 ms 20.49 ms
0979ac6 1217.96 ms 1244.88 ms 26.92 ms
f5f8910 1222.41 ms 1251.78 ms 29.37 ms
202334c 1265.41 ms 1277.34 ms 11.93 ms
8b040e4 1234.76 ms 1244.71 ms 9.95 ms
347a8e9 1243.50 ms 1265.90 ms 22.40 ms
5025d2e 1248.52 ms 1251.72 ms 3.20 ms
0fdf0b2 1245.88 ms 1247.69 ms 1.82 ms
bdfccaa 1202.83 ms 1228.96 ms 26.13 ms
b15627c 1256.48 ms 1264.68 ms 8.20 ms

App size

Revision Plain With Sentry Diff
4e037c4 20.50 KiB 361.79 KiB 341.29 KiB
0979ac6 20.50 KiB 342.31 KiB 321.81 KiB
f5f8910 20.75 KiB 368.04 KiB 347.29 KiB
202334c 20.51 KiB 331.79 KiB 311.28 KiB
8b040e4 20.50 KiB 333.54 KiB 313.04 KiB
347a8e9 20.51 KiB 333.16 KiB 312.65 KiB
5025d2e 20.51 KiB 331.79 KiB 311.28 KiB
0fdf0b2 20.51 KiB 332.90 KiB 312.39 KiB
bdfccaa 20.50 KiB 361.80 KiB 341.29 KiB
b15627c 20.50 KiB 337.76 KiB 317.25 KiB

@philipphofmann
philipphofmann merged commit cd8dad3 into master Nov 14, 2022
@philipphofmann
philipphofmann deleted the test/file-name-metric-kit branch November 14, 2022 09:42
kevinrenskers added a commit that referenced this pull request Nov 14, 2022
@kevinrenskers
Merge branch 'master' into feat/1777-no-session-update-for-dropped-ev…
7ebc668 
…ents

* master:
  test: Fix MetricKit attachment filename (#2379)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@armcknight armcknight Awaiting requested review from armcknight
1 more reviewer
@brustolin brustolin brustolin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@philipphofmann @brustolin