Skip to content

meta: Changelog link start-up crashes#2238

Merged
philipphofmann merged 1 commit into
masterfrom
philipphofmann-patch-1
Sep 29, 2022
Merged

meta: Changelog link start-up crashes#2238
philipphofmann merged 1 commit into
masterfrom
philipphofmann-patch-1

Conversation

@philipphofmann

Copy link
Copy Markdown
Member

The feature list will show start-up crashes after merging getsentry/sentry-docs#5579.

#skip-changelog

The feature list will show start-up crashes after merging getsentry/sentry-docs#5579.
Comment thread CHANGELOG.md
### Features

- Report start up crashes (#2220)
- Report [start up crashes](https://docs.sentry.io/platforms/apple/guides/ios/) (#2220)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is linking to a feature list really that useful? Isn't there a more specific page to link to?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a page for that, and I don't think we will add one. It's one sentence. Would you like to see a more detailed explanation of the feature?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case I am not sure the link adds any value at all, since it's a feature description linking to a feature description sentence within a rather big page. But no problem to merge it, it doesn't hurt either.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's better than nothing.

@philipphofmann
philipphofmann merged commit 0fdf0b2 into master Sep 29, 2022
@philipphofmann
philipphofmann deleted the philipphofmann-patch-1 branch September 29, 2022 13:29
kevinrenskers added a commit that referenced this pull request Sep 29, 2022
* master:
  meta: Changelog link start-up crashes (#2238)
  ci: Point to latest GH hash for VLC tests (#2237)
  ci: Fix typo in comments for tests.yml (#2241)
  release: 7.27.0
  feat: Support tracePropagationTargets (#2217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants