fix: Correctly attribute enterprise builds#2235
Merged
Merged
Conversation
kevinrenskers
requested review from
armcknight,
brustolin,
indragiek and
philipphofmann
as code owners
September 28, 2022 12:31
kevinrenskers
commented
Sep 28, 2022
| static NSString * | ||
| getReceiptUrlPath() | ||
| { | ||
| NSString *path = nil; |
Contributor
Author
There was a problem hiding this comment.
All these checks seemed a bit silly as we support iOS 9 and up.
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 864c39a | 1239.45 ms | 1256.76 ms | 17.31 ms |
| 4a66f00 | 1259.84 ms | 1281.66 ms | 21.82 ms |
| 4c1fab4 | 1222.96 ms | 1251.00 ms | 28.04 ms |
| 172c95a | 1220.08 ms | 1251.74 ms | 31.66 ms |
| 9fc2dd0 | 1246.14 ms | 1275.00 ms | 28.86 ms |
| 791123d | 1256.10 ms | 1266.68 ms | 10.58 ms |
| 791123d | 1217.52 ms | 1253.08 ms | 35.56 ms |
| 074350f | 1241.00 ms | 1249.60 ms | 8.60 ms |
| 202334c | 1265.41 ms | 1277.34 ms | 11.93 ms |
| 4a66f00 | 1224.73 ms | 1241.14 ms | 16.41 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 864c39a | 20.51 KiB | 335.57 KiB | 315.06 KiB |
| 4a66f00 | 20.51 KiB | 331.79 KiB | 311.28 KiB |
| 4c1fab4 | 20.51 KiB | 331.79 KiB | 311.28 KiB |
| 172c95a | 20.51 KiB | 335.57 KiB | 315.06 KiB |
| 9fc2dd0 | 20.50 KiB | 331.79 KiB | 311.28 KiB |
| 791123d | 20.51 KiB | 331.81 KiB | 311.30 KiB |
| 791123d | 20.51 KiB | 331.81 KiB | 311.30 KiB |
| 074350f | 20.51 KiB | 335.52 KiB | 315.01 KiB |
| 202334c | 20.51 KiB | 331.79 KiB | 311.28 KiB |
| 4a66f00 | 20.51 KiB | 331.79 KiB | 311.28 KiB |
philipphofmann
approved these changes
Sep 29, 2022
philipphofmann
left a comment
philipphofmann
left a comment
Member
There was a problem hiding this comment.
Let's give it a try. LGTM
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Correctly attribute enterprise builds ([#2235](https://github.com/getsentry/sentry-cocoa/pull/2235))If none of the above apply, you can opt out of this check by adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
This uses the check as suggested in the ticket, and I've found similar suggestions in StackOverflow and in HockeySDK-iOS (the old HockeyApp SDK). But I have no way of verifying this, and it feels a bit scary. I am also not sure how well this will age, maybe this will change with future iOS versions?
If users already have a way of overriding the build type, I am not 100% convinced we should add this to the SDK.
💡 Motivation and Context
Closes #778
💚 How did you test it?
Impossible :/
📝 Checklist
🔮 Next steps