feat: Add segment property to user#2234
Merged
Merged
Conversation
Add top-level property segment to user, instead of having to set it on the data dictionary with keeping backwards compatibility. Fixes GH-2149
philipphofmann
requested review from
armcknight,
brustolin and
indragiek
as code owners
September 28, 2022 09:39
Contributor
|
marandaneto
reviewed
Sep 28, 2022
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 791123d | 1256.10 ms | 1266.68 ms | 10.58 ms |
| 864c39a | 1239.45 ms | 1256.76 ms | 17.31 ms |
| 864c39a | 1226.12 ms | 1248.26 ms | 22.13 ms |
| 4a66f00 | 1259.84 ms | 1281.66 ms | 21.82 ms |
| 864c39a | 1191.14 ms | 1233.38 ms | 42.24 ms |
| 9fc2dd0 | 1246.14 ms | 1275.00 ms | 28.86 ms |
| 4a66f00 | 1224.73 ms | 1241.14 ms | 16.41 ms |
| 202334c | 1265.41 ms | 1277.34 ms | 11.93 ms |
| 791123d | 1217.52 ms | 1253.08 ms | 35.56 ms |
| 7138b7d | 1243.40 ms | 1252.08 ms | 8.68 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 791123d | 20.51 KiB | 331.81 KiB | 311.30 KiB |
| 864c39a | 20.51 KiB | 335.57 KiB | 315.06 KiB |
| 864c39a | 20.51 KiB | 335.57 KiB | 315.06 KiB |
| 4a66f00 | 20.51 KiB | 331.79 KiB | 311.28 KiB |
| 864c39a | 20.51 KiB | 335.57 KiB | 315.06 KiB |
| 9fc2dd0 | 20.50 KiB | 331.79 KiB | 311.28 KiB |
| 4a66f00 | 20.51 KiB | 331.79 KiB | 311.28 KiB |
| 202334c | 20.51 KiB | 331.79 KiB | 311.28 KiB |
| 791123d | 20.51 KiB | 331.81 KiB | 311.30 KiB |
| 7138b7d | 20.51 KiB | 331.79 KiB | 311.28 KiB |
kevinrenskers
approved these changes
Sep 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Add top-level property segment to the user instead of having to set it on the data dictionary.
Docs PR getsentry/sentry-docs#5575
💡 Motivation and Context
Fixes GH-2149
💚 How did you test it?
Unit tests
📝 Checklist
🔮 Next steps