ref: Clarify waitForChildren in SentryTracer#2230
Merged
Merged
Conversation
Clarify the concept of waitForChildren with renamings and adding some comments.
philipphofmann
requested review from
armcknight,
brustolin and
indragiek
as code owners
September 27, 2022 06:30
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9fc2dd0 | 1246.14 ms | 1275.00 ms | 28.86 ms |
| 202334c | 1265.41 ms | 1277.34 ms | 11.93 ms |
| 7138b7d | 1243.40 ms | 1252.08 ms | 8.68 ms |
| 4a66f00 | 1224.73 ms | 1241.14 ms | 16.41 ms |
| 4a66f00 | 1259.84 ms | 1281.66 ms | 21.82 ms |
| 172c95a | 1220.08 ms | 1251.74 ms | 31.66 ms |
| e43ce74 | 1235.77 ms | 1252.06 ms | 16.29 ms |
| 864c39a | 1239.45 ms | 1256.76 ms | 17.31 ms |
| 4c1fab4 | 1222.96 ms | 1251.00 ms | 28.04 ms |
| 5025d2e | 1245.14 ms | 1268.58 ms | 23.44 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9fc2dd0 | 20.50 KiB | 331.79 KiB | 311.28 KiB |
| 202334c | 20.51 KiB | 331.79 KiB | 311.28 KiB |
| 7138b7d | 20.51 KiB | 331.79 KiB | 311.28 KiB |
| 4a66f00 | 20.51 KiB | 331.79 KiB | 311.28 KiB |
| 4a66f00 | 20.51 KiB | 331.79 KiB | 311.28 KiB |
| 172c95a | 20.51 KiB | 335.57 KiB | 315.06 KiB |
| e43ce74 | 20.51 KiB | 335.49 KiB | 314.99 KiB |
| 864c39a | 20.51 KiB | 335.57 KiB | 315.06 KiB |
| 4c1fab4 | 20.51 KiB | 331.79 KiB | 311.28 KiB |
| 5025d2e | 20.51 KiB | 331.79 KiB | 311.28 KiB |
Previous results on branch: ref/tracer-wait-for-children
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 503b5f3 | 1229.20 ms | 1249.70 ms | 20.50 ms |
| 1e80682 | 1249.84 ms | 1260.98 ms | 11.14 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 503b5f3 | 20.51 KiB | 331.81 KiB | 311.30 KiB |
| 1e80682 | 20.51 KiB | 331.86 KiB | 311.35 KiB |
armcknight
approved these changes
Sep 27, 2022
armcknight
left a comment
armcknight
left a comment
Member
There was a problem hiding this comment.
Appreciate the help here 🙏🏻
kevinrenskers
approved these changes
Sep 27, 2022
Co-authored-by: Andrew McKnight <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify the concept of waitForChildren with renamings and adding some comments.
It was a bit confusing for @armcknight.
#skip-changelog